Changeset 92054 in webkit

Timestamp:

Jul 30, 2011 11:24:13 AM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic should strikeout revisions that have been rolled out
​https://bugs.webkit.org/show_bug.cgi?id=65227

Reviewed by Dimitri Glazkov.

This helps gardeners keep track of which problems have been solved.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js

@@ -71 +71 @@
 }
 
+function findRevert(message)
+{
+    var regexp = /rolling out r(\d+)\./;
+    var revision = findUsingRegExp(message, regexp);
+    if (!revision)
+        return undefined;
+    return parseInt(revision, 10);
+}
+
 // FIXME: Consider exposing this method for unit testing.
 function parseCommitData(responseXML)
@@ -92 +101 @@
             'bugID': findBugID(message),
             'message': message,
+            'revertedRevision': findRevert(message),
         };
     });

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css

@@ -167 +167 @@
 }
 
+.changelog .reverted {
+    text-decoration: line-through;
+}
+
 .changelog .possible-regression {
     background-color: PapayaWhip;

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js

@@ -7 +7 @@
 model.state = {};
 
+function findAndMarkRevertedRevisions(commitDataList)
+{
+    var revertedRevisions = {};
+    $.each(commitDataList, function(index, commitData) {
+        if (commitData.revertedRevision)
+            revertedRevisions[commitData.revertedRevision] = true;
+    });
+    $.each(commitDataList, function(index, commitData) {
+        if (commitData.revision in revertedRevisions)
+            commitData.wasReverted = true;
+    });
+}
+
 model.updateRecentCommits = function(callback)
 {
     trac.recentCommitData('trunk', kCommitLogLength, function(commitDataList) {
         model.state.recentCommits = commitDataList;
+        findAndMarkRevertedRevisions(model.state.recentCommits);
         callback();
     });

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js

@@ -127 +127 @@
     else
         $('.reviewer-container', entry).detach();
+    if (commitData.wasReverted)
+        entry.addClass('reverted');
 
     return entry;

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-30  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic should strikeout revisions that have been rolled out
+        https://bugs.webkit.org/show_bug.cgi?id=65227
+
+        Reviewed by Dimitri Glazkov.
+
+        This helps gardeners keep track of which problems have been solved.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
+
 2011-07-30  Adam Barth  <abarth@webkit.org>