Changeset 92134 in webkit


Ignore:
Timestamp:
Aug 1, 2011 12:23:21 PM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic shouldn't require local server to determine if compile failed
https://bugs.webkit.org/show_bug.cgi?id=65446

Reviewed by Dimitri Glazkov.

This patch adds some basic bindings for the buildbot JSON API. I
wanted to use Buildbot.js an Builder.js from the original TestFailures,
but they make a number of WebKit-specific assumptions. We'll
eventually need to reconcile these pieces of code.

I should really add tests for this code, but that will require me to
build a better mock network. I'll be happy to do that in a follow-up
patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
    • It's very unclear to me whether didFail is correct. Supposedly the first entry here is the exit code of the step, which is 0 on success. I suspect we'll need to improve this function over time.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
Location:
trunk/Tools
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html

    r92056 r92134  
    3333<script src="base.js"></script>
    3434<script src="Trac.js"></script>
     35<script src="builders.js"></script>
    3536<script src="checkout.js"></script>
    3637<script src="results.js"></script>
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js

    r92133 r92134  
    222222}
    223223
     224function showFailingBuildersInfobar(builderNameList)
     225{
     226    if (builderNameList.length)
     227        displayInfobar(ui.infobarMessageForCompileErrors(builderNameList), kBuildFailedInfobarType);
     228    else
     229        hideInfobarIfOfType(kBuildFailedInfobarType);
     230}
     231
    224232function update()
    225233{
    226234    displayOnButterbar('Loading...');
     235    builders.buildersFailingStepRequredForTestCoverage(showFailingBuildersInfobar);
    227236    base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
    228237        showRecentCommits();
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js

    r91677 r92134  
    452452};
    453453
    454 function isBuilderThatOnlyCompiles(builderName)
    455 {
    456     return config.kBuildersThatOnlyCompile.indexOf(builderName) != -1;
    457 }
    458 
    459 // FIXME: This method isn't tested because we don't have a good strategy for
    460 // mocking out the network. Maybe all network requests should go through a
    461 // "net" module?
    462 results.fetchBuildersWithCompileErrors = function(callback) {
    463     $.get('/buildbot', function(builderStatuses) {
    464         var brokenBuilders = [];
    465 
    466         $.each(builderStatuses, function(index, builderStatus) {
    467             if (builderStatus['is_green'])
    468                 return;
    469             var builderName = builderStatus['name'];
    470             if (isBuilderThatOnlyCompiles(builderName))
    471                 brokenBuilders.push(builderName);
    472         });
    473 
    474         callback(brokenBuilders);
    475     });
    476 };
    477 
    478454results.fetchResultsForBuilder = function(builderName, callback)
    479455{
  • trunk/Tools/ChangeLog

    r92133 r92134  
     12011-08-01  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic shouldn't require local server to determine if compile failed
     4        https://bugs.webkit.org/show_bug.cgi?id=65446
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        This patch adds some basic bindings for the buildbot JSON API.  I
     9        wanted to use Buildbot.js an Builder.js from the original TestFailures,
     10        but they make a number of WebKit-specific assumptions.  We'll
     11        eventually need to reconcile these pieces of code.
     12
     13        I should really add tests for this code, but that will require me to
     14        build a better mock network.  I'll be happy to do that in a follow-up
     15        patch.
     16
     17        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
     18            - It's very unclear to me whether didFail is correct.  Supposedly
     19              the first entry here is the exit code of the step, which is 0 on
     20              success.  I suspect we'll need to improve this function over time.
     21        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
     22        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
     23        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
     24
    1252011-08-01  Adam Barth  <abarth@webkit.org>
    226
Note: See TracChangeset for help on using the changeset viewer.