Changeset 92158 in webkit


Ignore:
Timestamp:
Aug 1, 2011 5:51:38 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
​https://bugs.webkit.org/show_bug.cgi?id=65451

Patch by Alice Boxhall <​aboxhall@chromium.org> on 2011-08-01
Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

LayoutTests:

  • accessibility/aria-roles.html:
  • platform/mac/accessibility/aria-multiline.html:
  • platform/mac/accessibility/aria-roles-expected.txt:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r92156 r92158  
     12011-08-01  Alice Boxhall  <aboxhall@chromium.org>
     2
     3        WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
     4        https://bugs.webkit.org/show_bug.cgi?id=65451
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/aria-roles.html:
     9        * platform/mac/accessibility/aria-multiline.html:
     10        * platform/mac/accessibility/aria-roles-expected.txt:
     11
    1122011-08-01  Zhenyao Mo  <zmo@google.com>
    213

  • trunk/LayoutTests/accessibility/aria-roles.html

    r35193 r92158  
    119119    <p><span tabindex="0" role="textbox" id="ariaTextBox">X</span></p>
    120120    <p>Actual text box:</p>
    121     <textarea id="realTextBox">Hello</textarea>
     121    <input type="text" id="realTextBox"></input>
    122122    <span id="resultTextBox"></span>
    123123    <script>

  • trunk/LayoutTests/platform/mac/accessibility/aria-multiline.html

    r74492 r92158  
    1010<body id="body">
    1111
    12 <div tabindex="0" id="textfield" role="textbox" aria-multiline="true">a</div>
    13 <div tabindex="0" id="textarea" role="textbox" aria-multiline="false">b</div>
     12<div tabindex="0" id="textfield" role="textbox" aria-multiline="false">a</div>
     13<div tabindex="0" id="textarea" role="textbox" aria-multiline="true">b</div>
    1414
    1515<p id="description"></p>

  • trunk/LayoutTests/platform/mac/accessibility/aria-roles-expected.txt

    r47676 r92158  
    5151Actual text box:
    5252
    53  This test PASSES in DumpRenderTree. The role is AXRole: AXTextArea
     53 This test PASSES in DumpRenderTree. The role is AXRole: AXTextField
    5454
    5555The following should be an image:

  • trunk/Source/WebCore/ChangeLog

    r92157 r92158  
     12011-08-01  Alice Boxhall  <aboxhall@chromium.org>
     2
     3        WAI-ARIA textbox role should be AXTextArea for aria-multiline=true, AXTextField for aria-multiline=false
     4        https://bugs.webkit.org/show_bug.cgi?id=65451
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/AccessibilityRenderObject.cpp:
     9        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
     10
    1112011-08-01  srikumar bonda  <srikumar.b@gmail.com>
    212

  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r92000 r92158  
    29972997        role = PopUpButtonRole;
    29982998
    2999     if (role == TextAreaRole && ariaIsMultiline())
     2999    if (role == TextAreaRole && !ariaIsMultiline())
    30003000        role = TextFieldRole;
    30013001   
Note: See TracChangeset for help on using the changeset viewer.