Changeset 92168 in webkit

Timestamp:

Aug 2, 2011 1:05:20 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix.
​https://bugs.webkit.org/show_bug.cgi?id=65467

Reviewed by Yury Semikhatsky.

• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._messagesClicked):

• inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement):

• inspector/front-end/inspector.css:

(.properties-tree li):
(.properties-tree li.parent::before):

• inspector/front-end/treeoutline.js:

(TreeElement.treeElementToggled):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ConsoleView.js (modified) (2 diffs)
• inspector/front-end/ObjectPropertiesSection.js (modified) (1 diff)
• inspector/front-end/inspector.css (modified) (2 diffs)
• inspector/front-end/treeoutline.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-02  Pavel Feldman  <pfeldman@google.com>
+
+        Web Inspector: arrow is a pain to click in console. Drive-by selection reset fix.
+        https://bugs.webkit.org/show_bug.cgi?id=65467
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/ConsoleView.js:
+        (WebInspector.ConsoleView.prototype._messagesClicked):
+        * inspector/front-end/ObjectPropertiesSection.js:
+        (WebInspector.ObjectPropertyTreeElement):
+        * inspector/front-end/inspector.css:
+        (.properties-tree li):
+        (.properties-tree li.parent::before):
+        * inspector/front-end/treeoutline.js:
+        (TreeElement.treeElementToggled):
+
 2011-08-01  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/inspector/front-end/ConsoleView.js

@@ -46 +46 @@
 
     this.messagesElement = document.getElementById("console-messages");
-    this.messagesElement.addEventListener("selectstart", this._messagesSelectStart.bind(this), false);
     this.messagesElement.addEventListener("click", this._messagesClicked.bind(this), true);
 
@@ -518 +517 @@
     },
 
-    _messagesSelectStart: function(event)
-    {
-        if (this._selectionTimeout)
-            clearTimeout(this._selectionTimeout);
-
-        this.prompt.clearAutoComplete();
-
-        function moveBackIfOutside()
-        {
-            delete this._selectionTimeout;
+    _messagesClicked: function(event)
+    {
+        var link = event.target.enclosingNodeOrSelfWithNodeName("a");
+        if (!link || !link.representedNode) {
             if (!this.prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)
                 this.prompt.moveCaretToEndOfPrompt();
-            this.prompt.autoCompleteSoon();
-        }
-
-        this._selectionTimeout = setTimeout(moveBackIfOutside.bind(this), 100);
-    },
-
-    _messagesClicked: function(event)
-    {
-        var link = event.target.enclosingNodeOrSelfWithNodeName("a");
-        if (!link || !link.representedNode)
             return;
+        }
 
         WebInspector.updateFocusedNode(link.representedNode.id);

trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

@@ -142 +142 @@
     // Pass an empty title, the title gets made later in onattach.
     TreeElement.call(this, "", null, false);
+    this.toggleOnClick = true;
+    this.selectable = false;
 }
 

trunk/Source/WebCore/inspector/front-end/inspector.css

@@ -1436 +1436 @@
     overflow: hidden;
     -webkit-user-select: text;
-    cursor: auto;
+    cursor: default;
 }
 
@@ -1452 +1452 @@
     padding-right: 3px;
     -webkit-user-select: none;
-    cursor: default;
 }
 

trunk/Source/WebCore/inspector/front-end/treeoutline.js

@@ -655 +655 @@
         return;
 
-    if (!element.treeElement.isEventWithinDisclosureTriangle(event))
+    var toggleOnClick = element.treeElement.toggleOnClick && !element.treeElement.selectable;
+    var isInTriangle = element.treeElement.isEventWithinDisclosureTriangle(event);
+    if (!toggleOnClick && !isInTriangle)
         return;