Changeset 92187 in webkit


Ignore:
Timestamp:
Aug 2, 2011 7:01:12 AM (13 years ago)
Author:
caseq@chromium.org
Message:

2011-08-01 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
​https://bugs.webkit.org/show_bug.cgi?id=65476

  • fixed webInspector.inspectedWindow.reload(), brought tests back.
  • removed redundant setting of user agent in FrameLoader::loadResourceSynchronously()

Reviewed by Yury Semikhatsky.

Test: http/tests/inspector/extensions-useragent.html

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):

2011-08-01 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
​https://bugs.webkit.org/show_bug.cgi?id=65476

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/extensions-useragent-expected.txt: Added.
  • http/tests/inspector/extensions-useragent.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r92185 r92187  
     12011-08-01  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=65476
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * http/tests/inspector/extensions-useragent-expected.txt: Added.
     9        * http/tests/inspector/extensions-useragent.html: Added.
     10
    1112011-08-02  Pavel Feldman  <pfeldman@chromium.org>
    212

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r92181 r92187  
    607607WONTFIX SKIP : http/tests/inspector/extensions-headers.html = FAIL
    608608WONTFIX SKIP : http/tests/inspector/extensions-resources-redirect.html = FAIL
     609WONTFIX SKIP : http/tests/inspector/extensions-useragent.html = FAIL
    609610
    610611// There is no enough plugins support in DRT

  • trunk/Source/WebCore/ChangeLog

    r92185 r92187  
     12011-08-01  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=65476
     5
     6        - fixed webInspector.inspectedWindow.reload(), brought tests back.
     7        - removed redundant setting of user agent in FrameLoader::loadResourceSynchronously()
     8
     9        Reviewed by Yury Semikhatsky.
     10
     11        Test: http/tests/inspector/extensions-useragent.html
     12
     13        * inspector/front-end/ExtensionServer.js:
     14        (WebInspector.ExtensionServer.prototype._onReload):
     15        * loader/FrameLoader.cpp:
     16        (WebCore::FrameLoader::loadResourceSynchronously):
     17
    1182011-08-02  Pavel Feldman  <pfeldman@chromium.org>
    219

  • trunk/Source/WebCore/inspector/front-end/ExtensionServer.js

    r91569 r92187  
    274274    {
    275275        if (typeof message.userAgent === "string")
    276             PageAgent.setUserAgentOverride(message.userAgent);
     276            NetworkAgent.setUserAgentOverride(message.userAgent);
    277277
    278278        PageAgent.reload(false);

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r92142 r92187  
    25802580    if (Page* page = m_frame->page())
    25812581        initialRequest.setFirstPartyForCookies(page->mainFrame()->loader()->documentLoader()->request().url());
    2582     initialRequest.setHTTPUserAgent(client()->userAgent(request.url()));
    25832582   
    25842583    addExtraFieldsToSubresourceRequest(initialRequest);
Note: See TracChangeset for help on using the changeset viewer.