Changeset 92190 in webkit

Timestamp:

Aug 2, 2011 8:18:31 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Remove overlapping recursive layout function
​https://bugs.webkit.org/show_bug.cgi?id=63241

First, _ewk_view_layout_if_needed_recursive is called twice in _ewk_view_smart_calculate
and _ewk_view_tiled_updates_process_pre,so it is no problem removing one of them.
Second, In tiled backingstore configuration, _ewk_view_layout_if_needed_recursive called
in _ewk_view_smart_calculate will result in generating repaints for dirty areas
located outside of viewport since m_paintEntireContents is set.
But, the areas will not be actually painted. Thus, the layout is unnecessary except
when there is something to paint inside of viewport, which will consume CPU unnecessarily.
So,the layout func was removed from _ewk_view_smart_calculate
and added to _ewk_view_single_smart_repaints_process for single backingstore.

Patch by Eunsol Park <​eunsol47.park@samsung.com> on 2011-08-02
Reviewed by Antonio Gomes.

• ewk/ewk_view.cpp:

(_ewk_view_smart_calculate):

• ewk/ewk_view_single.c:

(_ewk_view_single_smart_repaints_process):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (1 diff)
• ewk/ewk_view_single.c (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-08-02  Eunsol Park  <eunsol47.park@samsung.com>
+
+        [EFL] Remove overlapping recursive layout function 
+        https://bugs.webkit.org/show_bug.cgi?id=63241 
+
+        First, _ewk_view_layout_if_needed_recursive is called twice in _ewk_view_smart_calculate 
+        and _ewk_view_tiled_updates_process_pre,so it is no problem removing one of them.
+        Second, In tiled backingstore configuration, _ewk_view_layout_if_needed_recursive called 
+        in _ewk_view_smart_calculate will result in generating repaints for dirty areas 
+        located outside of viewport since m_paintEntireContents is set.
+        But, the areas will not be actually painted. Thus, the layout is unnecessary except
+        when there is something to paint inside of viewport, which will consume CPU unnecessarily.
+        So,the layout func was removed from _ewk_view_smart_calculate 
+        and added to _ewk_view_single_smart_repaints_process for single backingstore.
+
+        Reviewed by Antonio Gomes.
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_smart_calculate):
+        * ewk/ewk_view_single.c:
+        (_ewk_view_single_smart_repaints_process):
+
 2011-08-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -854 +854 @@
     sd->changed.position = EINA_FALSE;
 
-    ewk_view_layout_if_needed_recursive(sd->_priv);
-
     if (!sd->api->scrolls_process(sd))
         ERR("failed to process scrolls.");

trunk/Source/WebKit/efl/ewk/ewk_view_single.c

@@ -438 +438 @@
     }
 
+    ewk_view_layout_if_needed_recursive(sd->_priv);
+
     int sx, sy;
     ewk_frame_scroll_pos_get(sd->main_frame, &sx, &sy);