Changeset 92236 in webkit


Ignore:
Timestamp:
Aug 2, 2011 2:35:15 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Remove LegacyDefaultOptionalArguments flag from CSS IDL files
​https://bugs.webkit.org/show_bug.cgi?id=65341

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2011-08-02
Reviewed by Adam Barth.

No new tests. All existing tests pass.

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
Location:
trunk/Source/WebCore
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r92234 r92236  
     12011-08-02  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        Remove LegacyDefaultOptionalArguments flag from CSS IDL files
     4        https://bugs.webkit.org/show_bug.cgi?id=65341
     5
     6        Reviewed by Adam Barth.
     7
     8        No new tests. All existing tests pass.
     9
     10        * css/CSSMediaRule.idl:
     11        * css/CSSPrimitiveValue.idl:
     12        * css/CSSRuleList.idl:
     13        * css/CSSStyleDeclaration.idl:
     14        * css/CSSStyleSheet.idl:
     15        * css/CSSValueList.idl:
     16        * css/MediaList.idl:
     17        * css/MediaQueryList.idl:
     18        * css/MediaQueryListListener.idl:
     19        * css/StyleMedia.idl:
     20        * css/StyleSheetList.idl:
     21        * css/WebKitCSSKeyframesRule.idl:
     22        * css/WebKitCSSMatrix.idl:
     23
    1242011-08-02  Robert Kroeger  <rjkroege@chromium.org>
    225

  • trunk/Source/WebCore/css/CSSMediaRule.idl

    r89148 r92236  
    2222
    2323    // Introduced in DOM Level 2:
    24     interface [
    25         LegacyDefaultOptionalArguments,
    26     ] CSSMediaRule : CSSRule {
     24    interface CSSMediaRule : CSSRule {
    2725        readonly attribute MediaList media;
    2826        readonly attribute CSSRuleList cssRules;
    2927       
    30         [OldStyleObjC] unsigned long      insertRule(in DOMString rule,
    31                                                      in unsigned long index)
     28        [OldStyleObjC] unsigned long      insertRule(in [Optional=CallWithDefaultValue] DOMString rule,
     29                                                     in [Optional=CallWithDefaultValue] unsigned long index)
    3230            raises(DOMException);
    33         void               deleteRule(in unsigned long index)
     31        void               deleteRule(in [Optional=CallWithDefaultValue] unsigned long index)
    3432            raises(DOMException);
    3533    };

  • trunk/Source/WebCore/css/CSSPrimitiveValue.idl

    r89148 r92236  
    2020module css {
    2121
    22     interface [
    23         LegacyDefaultOptionalArguments,
    24     ] CSSPrimitiveValue : CSSValue {
     22    interface CSSPrimitiveValue : CSSValue {
    2523
    2624        // UnitTypes
    … …  
    5452        readonly attribute unsigned short primitiveType;
    5553
    56         [OldStyleObjC] void setFloatValue(in unsigned short unitType,
    57                                           in float floatValue)
     54        [OldStyleObjC] void setFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType,
     55                                          in [Optional=CallWithDefaultValue] float floatValue)
    5856            raises(DOMException);
    59         float getFloatValue(in unsigned short unitType)
     57        float getFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType)
    6058            raises(DOMException);
    61         [OldStyleObjC] void setStringValue(in unsigned short stringType,
    62                                            in DOMString stringValue)
     59        [OldStyleObjC] void setStringValue(in [Optional=CallWithDefaultValue] unsigned short stringType,
     60                                           in [Optional=CallWithDefaultValue] DOMString stringValue)
    6361            raises(DOMException);
    6462        DOMString getStringValue()

  • trunk/Source/WebCore/css/CSSRuleList.idl

    r89148 r92236  
    2828    // Introduced in DOM Level 2:
    2929    interface [
    30         LegacyDefaultOptionalArguments,
    3130        CustomIsReachable,
    3231        HasIndexGetter,
    … …  
    3433    ] CSSRuleList {
    3534        readonly attribute unsigned long    length;
    36         CSSRule           item(in unsigned long index);
     35        CSSRule           item(in [Optional=CallWithDefaultValue] unsigned long index);
    3736    };
    3837

  • trunk/Source/WebCore/css/CSSStyleDeclaration.idl

    r89148 r92236  
    2323    // Introduced in DOM Level 2:
    2424    interface [
    25         LegacyDefaultOptionalArguments,
    2625        CustomMarkFunction,
    2726        GenerateIsReachable=ImplRoot,
    … …  
    3433                     setter raises(DOMException);
    3534
    36         [ConvertNullStringTo=Null] DOMString          getPropertyValue(in DOMString propertyName);
    37         [JSCCustom] CSSValue           getPropertyCSSValue(in DOMString propertyName);
    38         [ConvertNullStringTo=Null] DOMString          removeProperty(in DOMString propertyName)
     35        [ConvertNullStringTo=Null] DOMString          getPropertyValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
     36        [JSCCustom] CSSValue           getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
     37        [ConvertNullStringTo=Null] DOMString          removeProperty(in [Optional=CallWithDefaultValue] DOMString propertyName)
    3938            raises(DOMException);
    40         [ConvertNullStringTo=Null] DOMString          getPropertyPriority(in DOMString propertyName);
    41         [OldStyleObjC] void setProperty(in DOMString propertyName,
    42                                         in [ConvertNullToNullString] DOMString value,
    43                                         in DOMString priority)
     39        [ConvertNullStringTo=Null] DOMString          getPropertyPriority(in [Optional=CallWithDefaultValue] DOMString propertyName);
     40        [OldStyleObjC] void setProperty(in [Optional=CallWithDefaultValue] DOMString propertyName,
     41                                        in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString value,
     42                                        in [Optional=CallWithDefaultValue] DOMString priority)
    4443            raises(DOMException);
    4544
    4645        readonly attribute unsigned long    length;
    47         DOMString          item(in unsigned long index);
     46        DOMString          item(in [Optional=CallWithDefaultValue] unsigned long index);
    4847        readonly attribute CSSRule          parentRule;
    4948
    5049        // Extensions
    51         [ConvertNullStringTo=Null] DOMString          getPropertyShorthand(in DOMString propertyName);
    52         boolean            isPropertyImplicit(in DOMString propertyName);
     50        [ConvertNullStringTo=Null] DOMString          getPropertyShorthand(in [Optional=CallWithDefaultValue] DOMString propertyName);
     51        boolean            isPropertyImplicit(in [Optional=CallWithDefaultValue] DOMString propertyName);
    5352    };
    5453

  • trunk/Source/WebCore/css/CSSStyleSheet.idl

    r89148 r92236  
    2222
    2323    // Introduced in DOM Level 2:
    24     interface [
    25         LegacyDefaultOptionalArguments,
    26     ] CSSStyleSheet : StyleSheet {
     24    interface CSSStyleSheet : StyleSheet {
    2725        readonly attribute CSSRule          ownerRule;
    2826        readonly attribute CSSRuleList      cssRules;
    2927
    30         [OldStyleObjC] unsigned long insertRule(in DOMString rule,
    31                                                 in unsigned long index)
     28        [OldStyleObjC] unsigned long insertRule(in [Optional=CallWithDefaultValue] DOMString rule,
     29                                                in [Optional=CallWithDefaultValue] unsigned long index)
    3230            raises(DOMException);
    33         void               deleteRule(in unsigned long index)
     31        void               deleteRule(in [Optional=CallWithDefaultValue] unsigned long index)
    3432            raises(DOMException);
    3533
    … …  
    3735        readonly attribute CSSRuleList      rules;
    3836
    39         long addRule(in DOMString selector,
    40                      in DOMString style,
     37        long addRule(in [Optional=CallWithDefaultValue] DOMString selector,
     38                     in [Optional=CallWithDefaultValue] DOMString style,
    4139                     in [Optional] unsigned long index)
    4240            raises(DOMException);
    43         void removeRule(in unsigned long index)
     41        void removeRule(in [Optional=CallWithDefaultValue] unsigned long index)
    4442            raises(DOMException);
    4543    };

  • trunk/Source/WebCore/css/CSSValueList.idl

    r89148 r92236  
    2828    // Introduced in DOM Level 2:
    2929    interface [
    30         LegacyDefaultOptionalArguments,
    3130        HasIndexGetter
    3231    ] CSSValueList : CSSValue {
    3332        readonly attribute unsigned long    length;
    34         CSSValue           item(in unsigned long index);
     33        CSSValue           item(in [Optional=CallWithDefaultValue] unsigned long index);
    3534    };
    3635

  • trunk/Source/WebCore/css/MediaList.idl

    r89148 r92236  
    2828    // Introduced in DOM Level 2:
    2929    interface [
    30         LegacyDefaultOptionalArguments,
    3130        GenerateIsReachable,
    3231        HasIndexGetter
    … …  
    3736        readonly attribute unsigned long length;
    3837
    39         [ConvertNullStringTo=Null] DOMString item(in unsigned long index);
    40         void deleteMedium(in DOMString oldMedium)
     38        [ConvertNullStringTo=Null] DOMString item(in [Optional=CallWithDefaultValue] unsigned long index);
     39        void deleteMedium(in [Optional=CallWithDefaultValue] DOMString oldMedium)
    4140            raises(DOMException);
    42         void appendMedium(in DOMString newMedium)
     41        void appendMedium(in [Optional=CallWithDefaultValue] DOMString newMedium)
    4342            raises(DOMException);
    4443

  • trunk/Source/WebCore/css/MediaQueryList.idl

    r89148 r92236  
    1919
    2020module view {
    21     interface [
    22         LegacyDefaultOptionalArguments,
    23     ] MediaQueryList {
     21    interface MediaQueryList {
    2422        readonly attribute DOMString media;
    2523        readonly attribute boolean matches;
    26         void addListener(in MediaQueryListListener listener);
    27         void removeListener(in MediaQueryListListener listener);
     24        void addListener(in [Optional=CallWithDefaultValue] MediaQueryListListener listener);
     25        void removeListener(in [Optional=CallWithDefaultValue] MediaQueryListListener listener);
    2826    };
    2927}

  • trunk/Source/WebCore/css/MediaQueryListListener.idl

    r89148 r92236  
    2020module view {
    2121    interface [
    22         LegacyDefaultOptionalArguments,
    2322        NoStaticTables,
    2423        ObjCProtocol,
    … …  
    2625        OmitConstructor
    2726    ] MediaQueryListListener {
    28         void queryChanged(in MediaQueryList list);
     27        void queryChanged(in [Optional=CallWithDefaultValue] MediaQueryList list);
    2928    };
    3029}

  • trunk/Source/WebCore/css/StyleMedia.idl

    r89148 r92236  
    2727module view {
    2828    interface [
    29         LegacyDefaultOptionalArguments,
    3029        GenerateIsReachable=ImplFrame
    3130    ] StyleMedia {
    3231        readonly attribute DOMString type;
    33         boolean matchMedium(in DOMString mediaquery);
     32        boolean matchMedium(in [Optional=CallWithDefaultValue] DOMString mediaquery);
    3433    };
    3534}

  • trunk/Source/WebCore/css/StyleSheetList.idl

    r89148 r92236  
    2323    // Introduced in DOM Level 2:
    2424    interface [
    25         LegacyDefaultOptionalArguments,
    2625        GenerateIsReachable=ImplDocument,
    2726        HasIndexGetter,
    … …  
    3029    ] StyleSheetList {
    3130        readonly attribute unsigned long    length;
    32         StyleSheet         item(in unsigned long index);
     31        StyleSheet         item(in [Optional=CallWithDefaultValue] unsigned long index);
    3332    };
    3433

  • trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl

    r89148 r92236  
    3131    // Introduced in DOM Level ?:
    3232    interface [
    33         LegacyDefaultOptionalArguments,
    3433        HasIndexGetter
    3534    ] WebKitCSSKeyframesRule : CSSRule {
    … …  
    3837        readonly attribute CSSRuleList cssRules;
    3938       
    40         void insertRule(in DOMString rule);
    41         void deleteRule(in DOMString key);
    42         WebKitCSSKeyframeRule findRule(in DOMString key);
     39        void insertRule(in [Optional=CallWithDefaultValue] DOMString rule);
     40        void deleteRule(in [Optional=CallWithDefaultValue] DOMString key);
     41        WebKitCSSKeyframeRule findRule(in [Optional=CallWithDefaultValue] DOMString key);
    4342    };
    4443

  • trunk/Source/WebCore/css/WebKitCSSMatrix.idl

    r89148 r92236  
    2828    // Introduced in DOM Level ?:
    2929    interface [
    30         LegacyDefaultOptionalArguments,
    3130        CanBeConstructed,
    3231        CustomConstructFunction,
    … …  
    6059        attribute double m44;
    6160
    62         void setMatrixValue(in DOMString string) raises (DOMException);
     61        void setMatrixValue(in [Optional=CallWithDefaultValue] DOMString string) raises (DOMException);
    6362       
    6463        // Multiply this matrix by secondMatrix, on the right (result = this * secondMatrix)
    65         [Immutable] WebKitCSSMatrix multiply(in WebKitCSSMatrix secondMatrix);
     64        [Immutable] WebKitCSSMatrix multiply(in [Optional=CallWithDefaultValue] WebKitCSSMatrix secondMatrix);
    6665       
    6766        // Return the inverse of this matrix. Throw an exception if the matrix is not invertible
    … …  
    7069        // Return this matrix translated by the passed values.
    7170        // Passing a NaN will use a value of 0. This allows the 3D form to used for 2D operations   
    72         [Immutable] WebKitCSSMatrix translate(in double x, in double y, in double z);
     71        [Immutable] WebKitCSSMatrix translate(in [Optional=CallWithDefaultValue] double x,
     72                                              in [Optional=CallWithDefaultValue] double y,
     73                                              in [Optional=CallWithDefaultValue] double z);
    7374       
    7475        // Returns this matrix scaled by the passed values.
    7576        // Passing scaleX or scaleZ as NaN uses a value of 1, but passing scaleY of NaN
    7677        // makes it the same as scaleX. This allows the 3D form to used for 2D operations
    77         [Immutable] WebKitCSSMatrix scale(in double scaleX, in double scaleY, in double scaleZ);
     78        [Immutable] WebKitCSSMatrix scale(in [Optional=CallWithDefaultValue] double scaleX,
     79                                          in [Optional=CallWithDefaultValue] double scaleY,
     80                                          in [Optional=CallWithDefaultValue] double scaleZ);
    7881       
    7982        // Returns this matrix rotated by the passed values.
    8083        // If rotY and rotZ are NaN, rotate about Z (rotX=0, rotateY=0, rotateZ=rotX).
    8184        // Otherwise use a rotation value of 0 for any passed NaN.   
    82         [Immutable] WebKitCSSMatrix rotate(in double rotX, in double rotY, in double rotZ);
     85        [Immutable] WebKitCSSMatrix rotate(in [Optional=CallWithDefaultValue] double rotX,
     86                                           in [Optional=CallWithDefaultValue] double rotY,
     87                                           in [Optional=CallWithDefaultValue] double rotZ);
    8388       
    8489        // Returns this matrix rotated about the passed axis by the passed angle.
    8590        // Passing a NaN will use a value of 0. If the axis is (0,0,0) use a value
    8691        // of (0,0,1).
    87         [Immutable] WebKitCSSMatrix rotateAxisAngle(in double x, in double y, in double z, in double angle);
     92        [Immutable] WebKitCSSMatrix rotateAxisAngle(in [Optional=CallWithDefaultValue] double x,
     93                                                    in [Optional=CallWithDefaultValue] double y,
     94                                                    in [Optional=CallWithDefaultValue] double z,
     95                                                    in [Optional=CallWithDefaultValue] double angle);
    8896
    8997        // Returns this matrix skewed along the X axis by the passed values.
    9098        // Passing a NaN will use a value of 0.
    91         [Immutable] WebKitCSSMatrix skewX(in double angle);
     99        [Immutable] WebKitCSSMatrix skewX(in [Optional=CallWithDefaultValue] double angle);
    92100
    93101        // Returns this matrix skewed along the Y axis by the passed values.
    94102        // Passing a NaN will use a value of 0.
    95         [Immutable] WebKitCSSMatrix skewY(in double angle);
     103        [Immutable] WebKitCSSMatrix skewY(in [Optional=CallWithDefaultValue] double angle);
    96104
    97105        [DontEnum] DOMString toString();
Note: See TracChangeset for help on using the changeset viewer.