Changeset 92239 in webkit

Timestamp:

Aug 2, 2011 3:17:51 PM (13 years ago)

Author:

gavinp@chromium.org

Message:

fail earlier to track down null CachedScript execution
​https://bugs.webkit.org/show_bug.cgi?id=65563

Over in ​http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.

Reviewed by Alexey Proskuryakov.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

• dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::queueScriptForExecution):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ScriptRunner.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-02  Gavin Peters  <gavinp@chromium.org>
+
+        fail earlier to track down null CachedScript execution
+        https://bugs.webkit.org/show_bug.cgi?id=65563
+
+        Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem.  Careful reading of the code hasn't led me
+        to an obvious cause either.  This patch should cause failure earlier, and lead to better stacks.  I'll watch Chrome Canary's crash
+        uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
+
+        Reviewed by Alexey Proskuryakov.
+
+        No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
+
+        * dom/ScriptRunner.cpp:
+        (WebCore::ScriptRunner::queueScriptForExecution):
+
 2011-08-02  Sailesh Agrawal  <sail@chromium.org>
 

trunk/Source/WebCore/dom/ScriptRunner.cpp

@@ -53 +53 @@
 {
     ASSERT(scriptElement);
+    
+    // Temporary: intended to help debug how null CachedScript objects can even get queued for execution, which
+    // seems to sometimes happen (see http://code.google.com/p/chromium/issues/detail?id=75604 )
+    if (!cachedScript.get())
+        CRASH();
 
     Element* element = scriptElement->element();