Changeset 92252 in webkit


Ignore:
Timestamp:
Aug 2, 2011 6:58:06 PM (13 years ago)
Author:
jchaffraix@webkit.org
Message:

RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
https://bugs.webkit.org/show_bug.cgi?id=65494

Reviewed by Darin Adler.

No new tests, const-ness change only.

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteClippedOverflowRect):
(WebCore::RenderObject::computeAbsoluteRepaintRect):
Made those 2 const as they call a const method now.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as
this is const.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::rectWithOutlineForRepaint):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:

(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeRectForRepaint):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):

  • rendering/svg/SVGRenderSupport.h:

Updated the following method's signature to use a const object.

Location:
trunk/Source/WebCore
Files:
35 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r92249 r92252  
     12011-08-02  Julien Chaffraix  <jchaffraix@webkit.org>
     2
     3        RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
     4        https://bugs.webkit.org/show_bug.cgi?id=65494
     5
     6        Reviewed by Darin Adler.
     7
     8        No new tests, const-ness change only.
     9
     10        * rendering/RenderObject.h:
     11        (WebCore::RenderObject::absoluteClippedOverflowRect):
     12        (WebCore::RenderObject::computeAbsoluteRepaintRect):
     13        Made those 2 const as they call a const method now.
     14
     15        * rendering/RenderInline.cpp:
     16        (WebCore::RenderInline::clippedOverflowRectForRepaint): Use a const RenderObject* for iterating as
     17        this is const.
     18
     19        * rendering/RenderBlock.cpp:
     20        (WebCore::RenderBlock::rectWithOutlineForRepaint):
     21        * rendering/RenderBlock.h:
     22        * rendering/RenderBox.cpp:
     23        (WebCore::RenderBox::clippedOverflowRectForRepaint):
     24        (WebCore::RenderBox::computeRectForRepaint):
     25        * rendering/RenderBox.h:
     26        * rendering/RenderInline.cpp:
     27        (WebCore::RenderInline::clippedOverflowRectForRepaint):
     28        (WebCore::RenderInline::rectWithOutlineForRepaint):
     29        (WebCore::RenderInline::computeRectForRepaint):
     30        * rendering/RenderInline.h:
     31        * rendering/RenderObject.cpp:
     32        (WebCore::RenderObject::rectWithOutlineForRepaint):
     33        (WebCore::RenderObject::clippedOverflowRectForRepaint):
     34        (WebCore::RenderObject::computeRectForRepaint):
     35        * rendering/RenderReplaced.cpp:
     36        (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
     37        * rendering/RenderReplaced.h:
     38        * rendering/RenderTableCell.cpp:
     39        (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
     40        (WebCore::RenderTableCell::computeRectForRepaint):
     41        * rendering/RenderTableCell.h:
     42        * rendering/RenderTableCol.cpp:
     43        (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
     44        * rendering/RenderTableCol.h:
     45        * rendering/RenderTableRow.cpp:
     46        (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
     47        * rendering/RenderTableRow.h:
     48        * rendering/RenderText.cpp:
     49        (WebCore::RenderText::clippedOverflowRectForRepaint):
     50        * rendering/RenderText.h:
     51        * rendering/RenderView.cpp:
     52        (WebCore::RenderView::computeRectForRepaint):
     53        * rendering/RenderView.h:
     54        * rendering/svg/RenderSVGForeignObject.cpp:
     55        (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
     56        (WebCore::RenderSVGForeignObject::computeRectForRepaint):
     57        * rendering/svg/RenderSVGForeignObject.h:
     58        * rendering/svg/RenderSVGGradientStop.h:
     59        (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
     60        * rendering/svg/RenderSVGHiddenContainer.h:
     61        (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
     62        * rendering/svg/RenderSVGInline.cpp:
     63        (WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
     64        (WebCore::RenderSVGInline::computeRectForRepaint):
     65        * rendering/svg/RenderSVGInline.h:
     66        * rendering/svg/RenderSVGModelObject.cpp:
     67        (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
     68        (WebCore::RenderSVGModelObject::computeRectForRepaint):
     69        * rendering/svg/RenderSVGModelObject.h:
     70        * rendering/svg/RenderSVGRoot.cpp:
     71        (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
     72        (WebCore::RenderSVGRoot::computeRectForRepaint):
     73        * rendering/svg/RenderSVGRoot.h:
     74        * rendering/svg/RenderSVGText.cpp:
     75        (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
     76        (WebCore::RenderSVGText::computeRectForRepaint):
     77        * rendering/svg/RenderSVGText.h:
     78        * rendering/svg/SVGRenderSupport.cpp:
     79        (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
     80        (WebCore::SVGRenderSupport::computeRectForRepaint):
     81        * rendering/svg/SVGRenderSupport.h:
     82        Updated the following method's signature to use a const object.
     83
    1842011-08-02  Jeffrey Pfau  <jpfau@apple.com>
    285
  • trunk/Source/WebCore/rendering/RenderBlock.cpp

    r92004 r92252  
    58295829}
    58305830
    5831 IntRect RenderBlock::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth)
     5831IntRect RenderBlock::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const
    58325832{
    58335833    IntRect r(RenderBox::rectWithOutlineForRepaint(repaintContainer, outlineWidth));
  • trunk/Source/WebCore/rendering/RenderBlock.h

    r92207 r92252  
    626626    virtual RenderBlock* firstLineBlock() const;
    627627
    628     virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth);
     628    virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const;
    629629    virtual RenderStyle* outlineStyleForRepaint() const;
    630630   
  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r92004 r92252  
    13801380}
    13811381
    1382 IntRect RenderBox::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     1382IntRect RenderBox::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    13831383{
    13841384    if (style()->visibility() != VISIBLE && !enclosingLayer()->hasVisibleContent())
     
    14111411}
    14121412
    1413 void RenderBox::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed)
     1413void RenderBox::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed) const
    14141414{
    14151415    // The rect we compute at each step is shifted by our x/y offset in the parent container's coordinate space.
  • trunk/Source/WebCore/rendering/RenderBox.h

    r92152 r92252  
    277277    void deleteLineBoxWrapper();
    278278
    279     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    280     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     279    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     280    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    281281
    282282    virtual void repaintDuringLayoutIfMoved(const LayoutRect&);
  • trunk/Source/WebCore/rendering/RenderInline.cpp

    r92059 r92252  
    955955}
    956956
    957 IntRect RenderInline::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     957IntRect RenderInline::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    958958{
    959959    // Only run-ins are allowed in here during layout.
     
    974974    // containing block.
    975975    RenderBlock* cb = containingBlock();
    976     for (RenderObject* inlineFlow = this; inlineFlow && inlineFlow->isRenderInline() && inlineFlow != cb;
     976    for (const RenderObject* inlineFlow = this; inlineFlow && inlineFlow->isRenderInline() && inlineFlow != cb;
    977977         inlineFlow = inlineFlow->parent()) {
    978978         if (inlineFlow->style()->position() == RelativePosition && inlineFlow->hasLayer())
     
    10181018}
    10191019
    1020 IntRect RenderInline::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth)
     1020IntRect RenderInline::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const
    10211021{
    10221022    IntRect r(RenderBoxModelObject::rectWithOutlineForRepaint(repaintContainer, outlineWidth));
     
    10281028}
    10291029
    1030 void RenderInline::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed)
     1030void RenderInline::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed) const
    10311031{
    10321032    if (RenderView* v = view()) {
  • trunk/Source/WebCore/rendering/RenderInline.h

    r90734 r92252  
    127127    virtual LayoutUnit offsetHeight() const { return linesBoundingBox().height(); }
    128128
    129     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    130     virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth);
    131     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed);
     129    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     130    virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const;
     131    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed) const;
    132132
    133133    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool fixed, bool useTransforms, TransformState&) const;
  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r91955 r92252  
    13531353}
    13541354
    1355 IntRect RenderObject::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth)
     1355IntRect RenderObject::rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const
    13561356{
    13571357    IntRect r(clippedOverflowRectForRepaint(repaintContainer));
     
    13601360}
    13611361
    1362 IntRect RenderObject::clippedOverflowRectForRepaint(RenderBoxModelObject*)
     1362IntRect RenderObject::clippedOverflowRectForRepaint(RenderBoxModelObject*) const
    13631363{
    13641364    ASSERT_NOT_REACHED();
     
    13661366}
    13671367
    1368 void RenderObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed)
     1368void RenderObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed) const
    13691369{
    13701370    if (repaintContainer == this)
  • trunk/Source/WebCore/rendering/RenderObject.h

    r91955 r92252  
    660660    // Returns the rect that should be repainted whenever this object changes.  The rect is in the view's
    661661    // coordinate space.  This method deals with outlines and overflow.
    662     IntRect absoluteClippedOverflowRect()
     662    IntRect absoluteClippedOverflowRect() const
    663663    {
    664664        return clippedOverflowRectForRepaint(0);
    665665    }
    666     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);   
    667     virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth);
     666    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     667    virtual IntRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, int outlineWidth) const;
    668668
    669669    // Given a rect in the object's coordinate space, compute a rect suitable for repainting
    670670    // that rect in view coordinates.
    671     void computeAbsoluteRepaintRect(IntRect& r, bool fixed = false)
     671    void computeAbsoluteRepaintRect(IntRect& r, bool fixed = false) const
    672672    {
    673673        return computeRectForRepaint(0, r, fixed);
     
    675675    // Given a rect in the object's coordinate space, compute a rect suitable for repainting
    676676    // that rect in the coordinate space of repaintContainer.
    677     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     677    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    678678
    679679    // If multiple-column layout results in applying an offset to the given point, add the same
  • trunk/Source/WebCore/rendering/RenderReplaced.cpp

    r91481 r92252  
    518518}
    519519
    520 IntRect RenderReplaced::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     520IntRect RenderReplaced::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    521521{
    522522    if (style()->visibility() != VISIBLE && !enclosingLayer()->hasVisibleContent())
  • trunk/Source/WebCore/rendering/RenderReplaced.h

    r91242 r92252  
    7676    virtual void paintReplaced(PaintInfo&, const LayoutPoint&) { }
    7777
    78     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
     78    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
    7979
    8080    virtual unsigned caretMaxRenderedOffset() const;
  • trunk/Source/WebCore/rendering/RenderTableCell.cpp

    r91417 r92252  
    230230}
    231231
    232 IntRect RenderTableCell::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     232IntRect RenderTableCell::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    233233{
    234234    // If the table grid is dirty, we cannot get reliable information about adjoining cells,
     
    282282}
    283283
    284 void RenderTableCell::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& r, bool fixed)
     284void RenderTableCell::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& r, bool fixed) const
    285285{
    286286    if (repaintContainer == this)
  • trunk/Source/WebCore/rendering/RenderTableCell.h

    r91417 r92252  
    148148
    149149    virtual LayoutSize offsetFromContainer(RenderObject*, const LayoutPoint&) const;
    150     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    151     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     150    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     151    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    152152
    153153    void paintCollapsedBorder(GraphicsContext*, const LayoutRect&);
  • trunk/Source/WebCore/rendering/RenderTableCol.cpp

    r68276 r92252  
    7070}
    7171
    72 IntRect RenderTableCol::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     72IntRect RenderTableCol::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    7373{
    7474    // For now, just repaint the whole table.
  • trunk/Source/WebCore/rendering/RenderTableCol.h

    r70072 r92252  
    5757    virtual bool requiresLayer() const { return false; }
    5858
    59     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
     59    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
    6060    virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
    6161
  • trunk/Source/WebCore/rendering/RenderTableRow.cpp

    r90675 r92252  
    170170}
    171171
    172 IntRect RenderTableRow::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     172IntRect RenderTableRow::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    173173{
    174174    ASSERT(parent());
  • trunk/Source/WebCore/rendering/RenderTableRow.h

    r90675 r92252  
    5454    virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0);
    5555    virtual void layout();
    56     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
     56    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
    5757    virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const LayoutPoint& pointInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
    5858
  • trunk/Source/WebCore/rendering/RenderText.cpp

    r91763 r92252  
    13601360}
    13611361
    1362 IntRect RenderText::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     1362IntRect RenderText::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    13631363{
    13641364    RenderObject* rendererToRepaint = containingBlock();
  • trunk/Source/WebCore/rendering/RenderText.h

    r90675 r92252  
    101101    virtual LayoutUnit marginRight() const { return style()->marginRight().calcMinValue(0); }
    102102
    103     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
     103    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
    104104
    105105    InlineTextBox* firstTextBox() const { return m_firstTextBox; }
  • trunk/Source/WebCore/rendering/RenderView.cpp

    r91760 r92252  
    302302}
    303303
    304 void RenderView::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed)
     304void RenderView::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& rect, bool fixed) const
    305305{
    306306    // If a container was specified, and was not 0 or the RenderView,
  • trunk/Source/WebCore/rendering/RenderView.h

    r91760 r92252  
    6868    FrameView* frameView() const { return m_frameView; }
    6969
    70     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     70    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    7171    virtual void repaintViewRectangle(const IntRect&, bool immediate = false);
    7272    // Repaint the view, and all composited layers that intersect the given absolute rectangle.
  • trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp

    r90734 r92252  
    6767}
    6868
    69 IntRect RenderSVGForeignObject::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     69IntRect RenderSVGForeignObject::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    7070{
    7171    return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContainer);
    7272}
    7373
    74 void RenderSVGForeignObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     74void RenderSVGForeignObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const
    7575{
    7676    SVGRenderSupport::computeRectForRepaint(this, repaintContainer, repaintRect, fixed);
  • trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h

    r90734 r92252  
    4040    virtual void paint(PaintInfo&, const LayoutPoint&);
    4141
    42     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    43     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     42    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     43    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    4444
    4545    virtual bool requiresLayer() const { return false; }
  • trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h

    r75350 r92252  
    4444    // RenderObject's default implementations ASSERT_NOT_REACHED()
    4545    // https://bugs.webkit.org/show_bug.cgi?id=20400
    46     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject*) { return IntRect(); }
     46    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject*) const { return IntRect(); }
    4747    virtual FloatRect objectBoundingBox() const { return FloatRect(); }
    4848    virtual FloatRect strokeBoundingBox() const { return FloatRect(); }
  • trunk/Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h

    r90048 r92252  
    4444    virtual void paint(PaintInfo&, const LayoutPoint&);
    4545   
    46     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject*) { return IntRect(); }
     46    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject*) const { return IntRect(); }
    4747    virtual void absoluteQuads(Vector<FloatQuad>&);
    4848
  • trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp

    r90734 r92252  
    6868}
    6969
    70 IntRect RenderSVGInline::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     70IntRect RenderSVGInline::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    7171{
    7272    return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContainer);
    7373}
    7474
    75 void RenderSVGInline::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     75void RenderSVGInline::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const
    7676{
    7777    SVGRenderSupport::computeRectForRepaint(this, repaintContainer, repaintRect, fixed);
  • trunk/Source/WebCore/rendering/svg/RenderSVGInline.h

    r90734 r92252  
    4646    virtual FloatRect repaintRectInLocalCoordinates() const;
    4747
    48     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    49     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     48    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     49    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    5050    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&) const;
    5151    virtual void absoluteQuads(Vector<FloatQuad>&);
  • trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp

    r91850 r92252  
    4444}
    4545
    46 IntRect RenderSVGModelObject::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     46IntRect RenderSVGModelObject::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    4747{
    4848    return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContainer);
    4949}
    5050
    51 void RenderSVGModelObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     51void RenderSVGModelObject::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const
    5252{
    5353    SVGRenderSupport::computeRectForRepaint(this, repaintContainer, repaintRect, fixed);
  • trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h

    r91850 r92252  
    5252    virtual bool requiresLayer() const { return false; }
    5353
    54     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    55     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     54    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     55    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    5656    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject* repaintContainer, IntPoint*) const;
    5757
  • trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

    r90734 r92252  
    395395}
    396396
    397 IntRect RenderSVGRoot::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     397IntRect RenderSVGRoot::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    398398{
    399399    return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContainer);
    400400}
    401401
    402 void RenderSVGRoot::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     402void RenderSVGRoot::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const
    403403{
    404404    // Apply our local transforms (except for x/y translation), then our shadow,
  • trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h

    r90734 r92252  
    8181    virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const LayoutPoint& pointInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
    8282
    83     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    84     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed);
     83    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     84    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const;
    8585
    8686    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&) const;
  • trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp

    r90734 r92252  
    8383}
    8484
    85 IntRect RenderSVGText::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
     85IntRect RenderSVGText::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
    8686{
    8787    return SVGRenderSupport::clippedOverflowRectForRepaint(this, repaintContainer);
    8888}
    8989
    90 void RenderSVGText::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     90void RenderSVGText::computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed) const
    9191{
    9292    SVGRenderSupport::computeRectForRepaint(this, repaintContainer, repaintRect, fixed);
  • trunk/Source/WebCore/rendering/svg/RenderSVGText.h

    r90734 r92252  
    6363    virtual void absoluteQuads(Vector<FloatQuad>&);
    6464
    65     virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer);
    66     virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false);
     65    virtual IntRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
     66    virtual void computeRectForRepaint(RenderBoxModelObject* repaintContainer, IntRect&, bool fixed = false) const;
    6767
    6868    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&) const;
  • trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp

    r90734 r92252  
    4646namespace WebCore {
    4747
    48 IntRect SVGRenderSupport::clippedOverflowRectForRepaint(RenderObject* object, RenderBoxModelObject* repaintContainer)
     48IntRect SVGRenderSupport::clippedOverflowRectForRepaint(const RenderObject* object, RenderBoxModelObject* repaintContainer)
    4949{
    5050    // Return early for any cases where we don't actually paint
     
    5959}
    6060
    61 void SVGRenderSupport::computeRectForRepaint(RenderObject* object, RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
     61void SVGRenderSupport::computeRectForRepaint(const RenderObject* object, RenderBoxModelObject* repaintContainer, IntRect& repaintRect, bool fixed)
    6262{
    6363    const SVGRenderStyle* svgStyle = object->style()->svgStyle();
  • trunk/Source/WebCore/rendering/svg/SVGRenderSupport.h

    r90734 r92252  
    6262
    6363    // Important functions used by nearly all SVG renderers centralizing coordinate transformations / repaint rect calculations
    64     static IntRect clippedOverflowRectForRepaint(RenderObject*, RenderBoxModelObject* repaintContainer);
    65     static void computeRectForRepaint(RenderObject*, RenderBoxModelObject* repaintContainer, IntRect&, bool fixed);
     64    static IntRect clippedOverflowRectForRepaint(const RenderObject*, RenderBoxModelObject* repaintContainer);
     65    static void computeRectForRepaint(const RenderObject*, RenderBoxModelObject* repaintContainer, IntRect&, bool fixed);
    6666    static void mapLocalToContainer(const RenderObject*, RenderBoxModelObject* repaintContainer, bool useTransforms, bool fixed, TransformState&);
    6767
Note: See TracChangeset for help on using the changeset viewer.