Changeset 92259 in webkit


Ignore:
Timestamp:
Aug 2, 2011 9:26:52 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r92256.
http://trac.webkit.org/changeset/92256
https://bugs.webkit.org/show_bug.cgi?id=65593

Causing tons of crashes on the chromium win bots (Requested by
jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-02

  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.cpp:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:
  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):

  • dom/WheelEvent.cpp:
  • dom/WheelEvent.h:
Location:
trunk/Source/WebCore
Files:
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r92256 r92259  
     12011-08-02  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r92256.
     4        http://trac.webkit.org/changeset/92256
     5        https://bugs.webkit.org/show_bug.cgi?id=65593
     6
     7        Causing tons of crashes on the chromium win bots (Requested by
     8        jamesr on #webkit).
     9
     10        * dom/Event.cpp:
     11        * dom/Event.h:
     12        * dom/EventDispatcher.cpp:
     13        (WebCore::EventDispatcher::dispatchEvent):
     14        * dom/EventDispatcher.h:
     15        * dom/KeyboardEvent.cpp:
     16        * dom/KeyboardEvent.h:
     17        * dom/MouseEvent.cpp:
     18        * dom/MouseEvent.h:
     19        * dom/Node.cpp:
     20        (WebCore::Node::dispatchEvent):
     21        (WebCore::Node::dispatchKeyEvent):
     22        (WebCore::Node::dispatchMouseEvent):
     23        (WebCore::Node::dispatchWheelEvent):
     24        * dom/WheelEvent.cpp:
     25        * dom/WheelEvent.h:
     26
    1272011-08-02  Hayato Ito  <hayato@chromium.org>
    228
  • trunk/Source/WebCore/dom/Event.cpp

    r92256 r92259  
    290290}
    291291
    292 PassRefPtr<EventDispatchMediator> EventDispatchMediator::create(PassRefPtr<Event> event)
    293 {
    294     return adoptRef(new EventDispatchMediator(event));
    295 }
    296 
    297292EventDispatchMediator::EventDispatchMediator(PassRefPtr<Event> event)
    298293    : m_event(event)
  • trunk/Source/WebCore/dom/Event.h

    r92256 r92259  
    200200    };
    201201
    202 class EventDispatchMediator : public RefCounted<Event> {
     202class EventDispatchMediator {
    203203public:
    204     static PassRefPtr<EventDispatchMediator> create(PassRefPtr<Event>);
     204    explicit EventDispatchMediator(PassRefPtr<Event>);
    205205    virtual ~EventDispatchMediator();
    206206
     
    208208
    209209protected:
    210     explicit EventDispatchMediator(PassRefPtr<Event>);
    211210    EventDispatchMediator();
    212211
  • trunk/Source/WebCore/dom/EventDispatcher.cpp

    r92256 r92259  
    4747static HashSet<Node*>* gNodesDispatchingSimulatedClicks = 0;
    4848
    49 bool EventDispatcher::dispatchEvent(Node* node, PassRefPtr<EventDispatchMediator> mediator)
     49bool EventDispatcher::dispatchEvent(Node* node, const EventDispatchMediator& mediator)
    5050{
    5151    ASSERT(!eventDispatchForbidden());
    5252
    5353    EventDispatcher dispatcher(node);
    54     return mediator->dispatchEvent(&dispatcher);
     54    return mediator.dispatchEvent(&dispatcher);
    5555}
    5656
  • trunk/Source/WebCore/dom/EventDispatcher.h

    r92256 r92259  
    4949class EventDispatcher {
    5050public:
    51     static bool dispatchEvent(Node*, PassRefPtr<EventDispatchMediator>);
     51    static bool dispatchEvent(Node*, const EventDispatchMediator&);
    5252    static void dispatchScopedEvent(Node*, PassRefPtr<Event>);
    53     static void dispatchScopedEventDispatchMediator(Node*, PassRefPtr<EventDispatchMediator>);
    5453
    5554    static void dispatchSimulatedClick(Node*, PassRefPtr<Event> underlyingEvent, bool sendMouseEvents, bool showPressedLook);
  • trunk/Source/WebCore/dom/KeyboardEvent.cpp

    r92256 r92259  
    160160}
    161161
    162 PassRefPtr<KeyboardEventDispatchMediator> KeyboardEventDispatchMediator::create(PassRefPtr<KeyboardEvent> event)
    163 {
    164     return adoptRef(new KeyboardEventDispatchMediator(event));
    165 }
    166 
    167162KeyboardEventDispatchMediator::KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent> event)
    168163    : EventDispatchMediator(event)
  • trunk/Source/WebCore/dom/KeyboardEvent.h

    r92256 r92259  
    118118class KeyboardEventDispatchMediator : public EventDispatchMediator {
    119119public:
    120     static PassRefPtr<KeyboardEventDispatchMediator> create(PassRefPtr<KeyboardEvent>);
     120    explicit KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent>);
     121
    121122private:
    122     explicit KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent>);
    123123    virtual bool dispatchEvent(EventDispatcher*) const;
    124124};
  • trunk/Source/WebCore/dom/MouseEvent.cpp

    r92256 r92259  
    160160}
    161161
    162 PassRefPtr<MouseEventDispatchMediator> MouseEventDispatchMediator::create(PassRefPtr<MouseEvent> mouseEvent)
    163 {
    164     return adoptRef(new MouseEventDispatchMediator(mouseEvent));
    165 }
    166 
    167162MouseEventDispatchMediator::MouseEventDispatchMediator(PassRefPtr<MouseEvent> mouseEvent)
    168163    : EventDispatchMediator(mouseEvent)
  • trunk/Source/WebCore/dom/MouseEvent.h

    r92256 r92259  
    101101class MouseEventDispatchMediator : public EventDispatchMediator {
    102102public:
    103     static PassRefPtr<MouseEventDispatchMediator> create(PassRefPtr<MouseEvent>);
     103    explicit MouseEventDispatchMediator(PassRefPtr<MouseEvent>);
    104104
    105105private:
    106     explicit MouseEventDispatchMediator(PassRefPtr<MouseEvent>);
    107106    MouseEvent* event() const;
    108107
  • trunk/Source/WebCore/dom/Node.cpp

    r92256 r92259  
    27152715bool Node::dispatchEvent(PassRefPtr<Event> event)
    27162716{
    2717     return EventDispatcher::dispatchEvent(this, EventDispatchMediator::create(event));
     2717    return EventDispatcher::dispatchEvent(this, EventDispatchMediator(event));
    27182718}
    27192719
     
    27472747bool Node::dispatchKeyEvent(const PlatformKeyboardEvent& event)
    27482748{
    2749     return EventDispatcher::dispatchEvent(this, KeyboardEventDispatchMediator::create(KeyboardEvent::create(event, document()->defaultView())));
     2749    return EventDispatcher::dispatchEvent(this, KeyboardEventDispatchMediator(KeyboardEvent::create(event, document()->defaultView())));
    27502750}
    27512751
     
    27532753    int detail, Node* relatedTarget)
    27542754{
    2755     return EventDispatcher::dispatchEvent(this, MouseEventDispatchMediator::create(MouseEvent::create(eventType, document()->defaultView(), event, detail, relatedTarget)));
     2755    return EventDispatcher::dispatchEvent(this, MouseEventDispatchMediator(MouseEvent::create(eventType, document()->defaultView(), event, detail, relatedTarget)));
    27562756}
    27572757
     
    27632763bool Node::dispatchWheelEvent(const PlatformWheelEvent& event)
    27642764{
    2765     return EventDispatcher::dispatchEvent(this, WheelEventDispatchMediator::create(event, document()->defaultView()));
     2765    return EventDispatcher::dispatchEvent(this, WheelEventDispatchMediator(event, document()->defaultView()));
    27662766}
    27672767
  • trunk/Source/WebCore/dom/WheelEvent.cpp

    r92256 r92259  
    9292}
    9393
    94 PassRefPtr<WheelEventDispatchMediator> WheelEventDispatchMediator::create(const PlatformWheelEvent& event, PassRefPtr<AbstractView> view)
    95 {
    96     return adoptRef(new WheelEventDispatchMediator(event, view));
    97 }
    98 
    9994WheelEventDispatchMediator::WheelEventDispatchMediator(const PlatformWheelEvent& event, PassRefPtr<AbstractView> view)
    10095{
  • trunk/Source/WebCore/dom/WheelEvent.h

    r92256 r92259  
    8484class WheelEventDispatchMediator : public EventDispatchMediator {
    8585public:
    86     static PassRefPtr<WheelEventDispatchMediator> create(const PlatformWheelEvent&, PassRefPtr<AbstractView>);
     86    WheelEventDispatchMediator(const PlatformWheelEvent&, PassRefPtr<AbstractView>);
     87
    8788private:
    88     WheelEventDispatchMediator(const PlatformWheelEvent&, PassRefPtr<AbstractView>);
    8989    WheelEvent* event() const;
    9090    virtual bool dispatchEvent(EventDispatcher*) const;
Note: See TracChangeset for help on using the changeset viewer.