Changeset 92259 in webkit
- Timestamp:
- Aug 2, 2011 9:26:52 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r92256 r92259 1 2011-08-02 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r92256. 4 http://trac.webkit.org/changeset/92256 5 https://bugs.webkit.org/show_bug.cgi?id=65593 6 7 Causing tons of crashes on the chromium win bots (Requested by 8 jamesr on #webkit). 9 10 * dom/Event.cpp: 11 * dom/Event.h: 12 * dom/EventDispatcher.cpp: 13 (WebCore::EventDispatcher::dispatchEvent): 14 * dom/EventDispatcher.h: 15 * dom/KeyboardEvent.cpp: 16 * dom/KeyboardEvent.h: 17 * dom/MouseEvent.cpp: 18 * dom/MouseEvent.h: 19 * dom/Node.cpp: 20 (WebCore::Node::dispatchEvent): 21 (WebCore::Node::dispatchKeyEvent): 22 (WebCore::Node::dispatchMouseEvent): 23 (WebCore::Node::dispatchWheelEvent): 24 * dom/WheelEvent.cpp: 25 * dom/WheelEvent.h: 26 1 27 2011-08-02 Hayato Ito <hayato@chromium.org> 2 28 -
trunk/Source/WebCore/dom/Event.cpp
r92256 r92259 290 290 } 291 291 292 PassRefPtr<EventDispatchMediator> EventDispatchMediator::create(PassRefPtr<Event> event)293 {294 return adoptRef(new EventDispatchMediator(event));295 }296 297 292 EventDispatchMediator::EventDispatchMediator(PassRefPtr<Event> event) 298 293 : m_event(event) -
trunk/Source/WebCore/dom/Event.h
r92256 r92259 200 200 }; 201 201 202 class EventDispatchMediator : public RefCounted<Event>{202 class EventDispatchMediator { 203 203 public: 204 static PassRefPtr<EventDispatchMediator> create(PassRefPtr<Event>);204 explicit EventDispatchMediator(PassRefPtr<Event>); 205 205 virtual ~EventDispatchMediator(); 206 206 … … 208 208 209 209 protected: 210 explicit EventDispatchMediator(PassRefPtr<Event>);211 210 EventDispatchMediator(); 212 211 -
trunk/Source/WebCore/dom/EventDispatcher.cpp
r92256 r92259 47 47 static HashSet<Node*>* gNodesDispatchingSimulatedClicks = 0; 48 48 49 bool EventDispatcher::dispatchEvent(Node* node, PassRefPtr<EventDispatchMediator>mediator)49 bool EventDispatcher::dispatchEvent(Node* node, const EventDispatchMediator& mediator) 50 50 { 51 51 ASSERT(!eventDispatchForbidden()); 52 52 53 53 EventDispatcher dispatcher(node); 54 return mediator ->dispatchEvent(&dispatcher);54 return mediator.dispatchEvent(&dispatcher); 55 55 } 56 56 -
trunk/Source/WebCore/dom/EventDispatcher.h
r92256 r92259 49 49 class EventDispatcher { 50 50 public: 51 static bool dispatchEvent(Node*, PassRefPtr<EventDispatchMediator>);51 static bool dispatchEvent(Node*, const EventDispatchMediator&); 52 52 static void dispatchScopedEvent(Node*, PassRefPtr<Event>); 53 static void dispatchScopedEventDispatchMediator(Node*, PassRefPtr<EventDispatchMediator>);54 53 55 54 static void dispatchSimulatedClick(Node*, PassRefPtr<Event> underlyingEvent, bool sendMouseEvents, bool showPressedLook); -
trunk/Source/WebCore/dom/KeyboardEvent.cpp
r92256 r92259 160 160 } 161 161 162 PassRefPtr<KeyboardEventDispatchMediator> KeyboardEventDispatchMediator::create(PassRefPtr<KeyboardEvent> event)163 {164 return adoptRef(new KeyboardEventDispatchMediator(event));165 }166 167 162 KeyboardEventDispatchMediator::KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent> event) 168 163 : EventDispatchMediator(event) -
trunk/Source/WebCore/dom/KeyboardEvent.h
r92256 r92259 118 118 class KeyboardEventDispatchMediator : public EventDispatchMediator { 119 119 public: 120 static PassRefPtr<KeyboardEventDispatchMediator> create(PassRefPtr<KeyboardEvent>); 120 explicit KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent>); 121 121 122 private: 122 explicit KeyboardEventDispatchMediator(PassRefPtr<KeyboardEvent>);123 123 virtual bool dispatchEvent(EventDispatcher*) const; 124 124 }; -
trunk/Source/WebCore/dom/MouseEvent.cpp
r92256 r92259 160 160 } 161 161 162 PassRefPtr<MouseEventDispatchMediator> MouseEventDispatchMediator::create(PassRefPtr<MouseEvent> mouseEvent)163 {164 return adoptRef(new MouseEventDispatchMediator(mouseEvent));165 }166 167 162 MouseEventDispatchMediator::MouseEventDispatchMediator(PassRefPtr<MouseEvent> mouseEvent) 168 163 : EventDispatchMediator(mouseEvent) -
trunk/Source/WebCore/dom/MouseEvent.h
r92256 r92259 101 101 class MouseEventDispatchMediator : public EventDispatchMediator { 102 102 public: 103 static PassRefPtr<MouseEventDispatchMediator> create(PassRefPtr<MouseEvent>);103 explicit MouseEventDispatchMediator(PassRefPtr<MouseEvent>); 104 104 105 105 private: 106 explicit MouseEventDispatchMediator(PassRefPtr<MouseEvent>);107 106 MouseEvent* event() const; 108 107 -
trunk/Source/WebCore/dom/Node.cpp
r92256 r92259 2715 2715 bool Node::dispatchEvent(PassRefPtr<Event> event) 2716 2716 { 2717 return EventDispatcher::dispatchEvent(this, EventDispatchMediator ::create(event));2717 return EventDispatcher::dispatchEvent(this, EventDispatchMediator(event)); 2718 2718 } 2719 2719 … … 2747 2747 bool Node::dispatchKeyEvent(const PlatformKeyboardEvent& event) 2748 2748 { 2749 return EventDispatcher::dispatchEvent(this, KeyboardEventDispatchMediator ::create(KeyboardEvent::create(event, document()->defaultView())));2749 return EventDispatcher::dispatchEvent(this, KeyboardEventDispatchMediator(KeyboardEvent::create(event, document()->defaultView()))); 2750 2750 } 2751 2751 … … 2753 2753 int detail, Node* relatedTarget) 2754 2754 { 2755 return EventDispatcher::dispatchEvent(this, MouseEventDispatchMediator ::create(MouseEvent::create(eventType, document()->defaultView(), event, detail, relatedTarget)));2755 return EventDispatcher::dispatchEvent(this, MouseEventDispatchMediator(MouseEvent::create(eventType, document()->defaultView(), event, detail, relatedTarget))); 2756 2756 } 2757 2757 … … 2763 2763 bool Node::dispatchWheelEvent(const PlatformWheelEvent& event) 2764 2764 { 2765 return EventDispatcher::dispatchEvent(this, WheelEventDispatchMediator ::create(event, document()->defaultView()));2765 return EventDispatcher::dispatchEvent(this, WheelEventDispatchMediator(event, document()->defaultView())); 2766 2766 } 2767 2767 -
trunk/Source/WebCore/dom/WheelEvent.cpp
r92256 r92259 92 92 } 93 93 94 PassRefPtr<WheelEventDispatchMediator> WheelEventDispatchMediator::create(const PlatformWheelEvent& event, PassRefPtr<AbstractView> view)95 {96 return adoptRef(new WheelEventDispatchMediator(event, view));97 }98 99 94 WheelEventDispatchMediator::WheelEventDispatchMediator(const PlatformWheelEvent& event, PassRefPtr<AbstractView> view) 100 95 { -
trunk/Source/WebCore/dom/WheelEvent.h
r92256 r92259 84 84 class WheelEventDispatchMediator : public EventDispatchMediator { 85 85 public: 86 static PassRefPtr<WheelEventDispatchMediator> create(const PlatformWheelEvent&, PassRefPtr<AbstractView>); 86 WheelEventDispatchMediator(const PlatformWheelEvent&, PassRefPtr<AbstractView>); 87 87 88 private: 88 WheelEventDispatchMediator(const PlatformWheelEvent&, PassRefPtr<AbstractView>);89 89 WheelEvent* event() const; 90 90 virtual bool dispatchEvent(EventDispatcher*) const;
Note: See TracChangeset
for help on using the changeset viewer.