Changeset 92541 in webkit


Ignore:
Timestamp:
Aug 5, 2011 7:25:57 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.

Patch by Tom Hudson <tomhudson@google.com> on 2011-08-05
Reviewed by James Robinson.

No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:

(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r92538 r92541  
     12011-08-05  Tom Hudson  <tomhudson@google.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=64613
     4        Use supported framebuffer renderbuffer mode; chromium command buffer
     5        allows DEPTH and STENCIL but not DEPTH_STENCIL.
     6
     7        Reviewed by James Robinson.
     8
     9        No new tests because was caught by extant tests, albeit only when
     10        accelerated drawing and forced compositing were both turned on.
     11
     12        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
     13        (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
     14
    1152011-08-05  Anna Cavender  <annacc@chromium.org>
    216
  • trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp

    r90670 r92541  
    230230    context()->bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
    231231    context()->renderbufferStorage(GraphicsContext3D::RENDERBUFFER, Extensions3D::DEPTH24_STENCIL8, m_bufferSize.width(), m_bufferSize.height());
    232     context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::DEPTH_STENCIL_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
     232    context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::DEPTH_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
     233    context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::STENCIL_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
    233234
    234235    // Create a skia gpu canvas.
Note: See TracChangeset for help on using the changeset viewer.