Changeset 92574 in webkit

Timestamp:

Aug 7, 2011 12:42:21 PM (13 years ago)

Author:

Joseph Pecoraro

Message:

[QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
​https://bugs.webkit.org/show_bug.cgi?id=65790

Reviewed by Sam Weinig.

Fix a leak by adopting an allocation instead of retaining it.

• UIProcess/qt/qwkhistory.cpp:

(QWKHistoryItem::title):
(QWKHistoryItem::url):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/qt/qwkhistory.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-08-07  Joseph Pecoraro  <joepeck@webkit.org>
+
+        [QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy
+        https://bugs.webkit.org/show_bug.cgi?id=65790
+
+        Reviewed by Sam Weinig.
+
+        Fix a leak by adopting an allocation instead of retaining it.
+
+        * UIProcess/qt/qwkhistory.cpp:
+        (QWKHistoryItem::title):
+        (QWKHistoryItem::url):
+
 2011-08-06  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebKit2/UIProcess/qt/qwkhistory.cpp

@@ -74 +74 @@
     if (!d->m_backForwardListItem)
         return QString();
-    WKRetainPtr<WKStringRef> title = WKBackForwardListItemCopyTitle(d->m_backForwardListItem.get());
+    WKRetainPtr<WKStringRef> title(AdoptWK, WKBackForwardListItemCopyTitle(d->m_backForwardListItem.get()));
     return WKStringCopyQString(title.get());
 }
@@ -82 +82 @@
     if (!d->m_backForwardListItem)
         return QUrl();
-    WKRetainPtr<WKURLRef> url = WKBackForwardListItemCopyURL(d->m_backForwardListItem.get());
+    WKRetainPtr<WKURLRef> url(AdoptWK, WKBackForwardListItemCopyURL(d->m_backForwardListItem.get()));
     return WKURLCopyQUrl(url.get());
 }