Changeset 92627 in webkit

Timestamp:

Aug 8, 2011 1:18:33 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Add detail to ASSERT message in IDBTransaction::enqueueEvent
​https://bugs.webkit.org/show_bug.cgi?id=65735

I've hit this a few times but haven't been able to pin it down. The
extra detail could be helpful.

Patch by David Grogan <​dgrogan@chromium.org> on 2011-08-08
Reviewed by Nate Chapin.

No new tests, just an error message.

• storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::enqueueEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• storage/IDBTransaction.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-08  David Grogan  <dgrogan@chromium.org>
+
+        Add detail to ASSERT message in IDBTransaction::enqueueEvent
+        https://bugs.webkit.org/show_bug.cgi?id=65735
+
+        I've hit this a few times but haven't been able to pin it down.  The
+        extra detail could be helpful.
+
+        Reviewed by Nate Chapin.
+
+        No new tests, just an error message.
+
+        * storage/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::enqueueEvent):
+
 2011-08-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/storage/IDBTransaction.cpp

@@ -183 +183 @@
 void IDBTransaction::enqueueEvent(PassRefPtr<Event> event)
 {
-    ASSERT(!m_finished);
+    ASSERT_WITH_MESSAGE(!m_finished, "A finished transaction tried to enqueue an event of type %s.", event->type().string().utf8().data());
     if (!scriptExecutionContext())
         return;