Changeset 92743 in webkit

Timestamp:

Aug 9, 2011 6:49:02 PM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic should use huerstics to narrow regression range
​https://bugs.webkit.org/show_bug.cgi?id=65948

Reviewed by Dimitri Glazkov.

When analyzing a regression range, if one of the commit messages
mentions the test in question, we now hueristically assume that
revision caused the failure. (I'm shamelessly stealing this idea from
TestFailures.)

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js

@@ -46 +46 @@
             commitData.wasReverted = true;
     });
+}
+
+function fuzzyFind(testName, commitData)
+{
+    var indexOfLastDot = testName.lastIndexOf('.');
+    var stem = indexOfLastDot == -1 ? testName : testName.substr(0, indexOfLastDot);
+    return commitData.message.indexOf(stem) != -1;
+}
+
+function heuristicallyNarrowRegressionRange(failureAnalysis)
+{
+    var commitDataList = model.state.recentCommits;
+    var commitDataIndex = commitDataList.length - 1;
+
+    for(var revision = failureAnalysis.newestPassingRevision + 1; revision <= failureAnalysis.oldestFailingRevision; ++revision) {
+        while (commitDataIndex >= 0 && commitDataList[commitDataIndex].revision < revision)
+            --commitDataIndex;
+        var commitData = commitDataList[commitDataIndex];
+        if (commitData.revision != revision)
+            continue;
+        if (fuzzyFind(failureAnalysis.testName, commitData)) {
+            failureAnalysis.oldestFailingRevision = revision;
+            failureAnalysis.newestPassingRevision = revision - 1;
+            return;
+        }
+    }
 }
 
@@ -108 +134 @@
             };
 
+            heuristicallyNarrowRegressionRange(failureAnalysis);
+
             var previousFailureAnalysis = model.state.failureAnalysisByTest[testName];
             if (previousFailureAnalysis

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-09  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic should use huerstics to narrow regression range
+        https://bugs.webkit.org/show_bug.cgi?id=65948
+
+        Reviewed by Dimitri Glazkov.
+
+        When analyzing a regression range, if one of the commit messages
+        mentions the test in question, we now hueristically assume that
+        revision caused the failure.  (I'm shamelessly stealing this idea from
+        TestFailures.)
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
+
 2011-07-13  Eric Seidel  <eric@webkit.org>