Changeset 92744 in webkit

Timestamp:

Aug 9, 2011 7:04:06 PM (13 years ago)

Author:

abarth@webkit.org

Message:

Source/WebCore: Style change not propagating for before, after content
for table parts.
​https://bugs.webkit.org/show_bug.cgi?id=51862

Fix by Chris Evans (​cevans@chromium.org).
In the table case, make sure to return the before /
after parent rather then the before / after node
itself.

Patch by Abhishek Arya <​inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

• rendering/RenderObjectChildList.cpp:

(WebCore::findBeforeAfterParent):

LayoutTests: Fix functional bug where style change was not getting propogated to before, after
content.
​https://bugs.webkit.org/show_bug.cgi?id=51862

Patch by Abhishek Arya <​inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.

• platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
• platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png (modified) (previous)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObjectChildList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-09  Abhishek Arya  <inferno@chromium.org>
+
+        Fix functional bug where style change was not getting propogated to before, after
+        content.
+        https://bugs.webkit.org/show_bug.cgi?id=51862
+
+        Reviewed by Simon Fraser.
+
+        * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
+        * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
+
 2011-08-09  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-09  Abhishek Arya  <inferno@chromium.org>
+
+        Style change not propagating for before, after content
+        for table parts.
+        https://bugs.webkit.org/show_bug.cgi?id=51862
+
+        Fix by Chris Evans (cevans@chromium.org).
+        In the table case, make sure to return the before /
+        after parent rather then the before / after node
+        itself.
+
+        Reviewed by Simon Fraser.
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::findBeforeAfterParent):
+
 2011-08-09  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

@@ -259 +259 @@
     while (beforeAfterParent && !(beforeAfterParent->isText() || beforeAfterParent->isImage()))
         beforeAfterParent = beforeAfterParent->firstChild();
-    return beforeAfterParent;
+    return beforeAfterParent ? beforeAfterParent->parent() : 0;
 }