Changeset 92747 in webkit


Ignore:
Timestamp:
Aug 9, 2011 9:51:50 PM (13 years ago)
Author:
dominicc@chromium.org
Message:

[V8] The prototype property of DOM constructors should be read-only.
https://bugs.webkit.org/show_bug.cgi?id=39655

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/prototype-property.html

  • bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.

(WebCore::ConfigureV8TestInterfaceTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

LayoutTests:

  • platform/chromium/test_expectations.txt: Unskip test for prototypes.
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r92746 r92747  
     12011-08-09  Dominic Cooney  <dominicc@chromium.org>
     2
     3        [V8] The prototype property of DOM constructors should be read-only.
     4        https://bugs.webkit.org/show_bug.cgi?id=39655
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * platform/chromium/test_expectations.txt: Unskip test for prototypes.
     9
    1102011-08-09  Kent Tamura  <tkent@chromium.org>
    211
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r92730 r92747  
    19551955BUGCR62301 MAC : canvas/philip/tests/2d.shadow.enable.y.html = TEXT
    19561956BUGCR62301 MAC : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT
    1957 
    1958 BUGWK39655 : fast/dom/prototype-property.html = FAIL
    19591957
    19601958// These SVG tests have been flaky on Win from quite some time.
  • trunk/Source/WebCore/ChangeLog

    r92744 r92747  
     12011-08-09  Dominic Cooney  <dominicc@chromium.org>
     2
     3        [V8] The prototype property of DOM constructors should be read-only.
     4        https://bugs.webkit.org/show_bug.cgi?id=39655
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Test: fast/dom/prototype-property.html
     9
     10        * bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
     11        * bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.
     12        (WebCore::ConfigureV8TestInterfaceTemplate):
     13        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
     14        (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
     15        * bindings/scripts/test/V8/V8TestObj.cpp:
     16        (WebCore::ConfigureV8TestObjTemplate):
     17        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
     18        (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
     19
    1202011-08-09  Abhishek Arya  <inferno@chromium.org>
    221
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r92313 r92747  
    20162016static v8::Persistent<v8::FunctionTemplate> Configure${className}Template(v8::Persistent<v8::FunctionTemplate> desc)
    20172017{
     2018    desc->ReadOnlyPrototype();
     2019
    20182020    v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, \"${visibleInterfaceName}\", $parentClassTemplate, V8${interfaceName}::internalFieldCount,
    20192021END
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp

    r89358 r92747  
    4949static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestInterfaceTemplate(v8::Persistent<v8::FunctionTemplate> desc)
    5050{
     51    desc->ReadOnlyPrototype();
     52
    5153    v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestInterface", v8::Persistent<v8::FunctionTemplate>(), V8TestInterface::internalFieldCount,
    5254        0, 0,
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp

    r89358 r92747  
    5656static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestMediaQueryListListenerTemplate(v8::Persistent<v8::FunctionTemplate> desc)
    5757{
     58    desc->ReadOnlyPrototype();
     59
    5860    v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestMediaQueryListListener", v8::Persistent<v8::FunctionTemplate>(), V8TestMediaQueryListListener::internalFieldCount,
    5961        0, 0,
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r90949 r92747  
    12881288static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestObjTemplate(v8::Persistent<v8::FunctionTemplate> desc)
    12891289{
     1290    desc->ReadOnlyPrototype();
     1291
    12901292    v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestObj", v8::Persistent<v8::FunctionTemplate>(), V8TestObj::internalFieldCount,
    12911293        TestObjAttrs, WTF_ARRAY_LENGTH(TestObjAttrs),
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp

    r89358 r92747  
    4545static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestSerializedScriptValueInterfaceTemplate(v8::Persistent<v8::FunctionTemplate> desc)
    4646{
     47    desc->ReadOnlyPrototype();
     48
    4749    v8::Local<v8::Signature> defaultSignature = configureTemplate(desc, "TestSerializedScriptValueInterface", v8::Persistent<v8::FunctionTemplate>(), V8TestSerializedScriptValueInterface::internalFieldCount,
    4850        0, 0,
Note: See TracChangeset for help on using the changeset viewer.