Changeset 92997 in webkit


Ignore:
Timestamp:
Aug 12, 2011 2:28:37 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebKit/chromium: Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

Tools: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollBegin):
(EventSender::gestureScrollEnd):
(EventSender::gestureTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

LayoutTests: DRT: Add support for gesture events.
https://bugs.webkit.org/show_bug.cgi?id=66105

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-12
Reviewed by Darin Fisher.

  • fast/events/touch/gesture/gesture-click-expected.txt: Added.
  • fast/events/touch/gesture/gesture-click.html: Added.
  • platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.
Location:
trunk
Files:
5 added
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r92993 r92997  
     12011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
     2
     3        DRT: Add support for gesture events.
     4        https://bugs.webkit.org/show_bug.cgi?id=66105
     5
     6        Reviewed by Darin Fisher.
     7
     8        * fast/events/touch/gesture/gesture-click-expected.txt: Added.
     9        * fast/events/touch/gesture/gesture-click.html: Added.
     10        * platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt: Added.
     11
    1122011-08-12  David Hyatt  <hyatt@apple.com>
    213
  • trunk/Source/WebKit/chromium/ChangeLog

    r92989 r92997  
     12011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
     2
     3        Wire gesture tap events, add support for gesture events in the DRT and add a layout test for it.
     4        https://bugs.webkit.org/show_bug.cgi?id=66105
     5
     6        Reviewed by Darin Fisher.
     7
     8        * public/WebInputEvent.h:
     9        * src/WebInputEventConversion.cpp:
     10        (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
     11        * src/WebPopupMenuImpl.cpp:
     12        (WebKit::WebPopupMenuImpl::handleInputEvent):
     13        * src/WebViewImpl.cpp:
     14        (WebKit::WebViewImpl::handleInputEvent):
     15
    1162011-08-12  Tommy Widenflycht  <tommyw@google.com>
    217
  • trunk/Source/WebKit/chromium/public/WebInputEvent.h

    r92699 r92997  
    104104        GestureScrollBegin,
    105105        GestureScrollEnd,
     106        GestureTap,
    106107
    107108        // WebTouchEvent
  • trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp

    r92699 r92997  
    121121        m_type = PlatformGestureEvent::ScrollEndType;
    122122        break;
     123    case WebInputEvent::GestureTap:
     124        m_type = PlatformGestureEvent::TapType;
     125        break;
    123126    default:
    124127        ASSERT_NOT_REACHED();
  • trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp

    r92983 r92997  
    274274    case WebInputEvent::GestureScrollBegin:
    275275    case WebInputEvent::GestureScrollEnd:
     276    case WebInputEvent::GestureTap:
    276277        return GestureEvent(*static_cast<const WebGestureEvent*>(&inputEvent));
    277278
  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r92983 r92997  
    12731273    case WebInputEvent::GestureScrollBegin:
    12741274    case WebInputEvent::GestureScrollEnd:
     1275    case WebInputEvent::GestureTap:
    12751276        handled = gestureEvent(*static_cast<const WebGestureEvent*>(&inputEvent));
    12761277        break;
  • trunk/Tools/ChangeLog

    r92984 r92997  
     12011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
     2
     3        DRT: Add support for gesture events.
     4        https://bugs.webkit.org/show_bug.cgi?id=66105
     5
     6        Reviewed by Darin Fisher.
     7
     8        * DumpRenderTree/chromium/EventSender.cpp:
     9        (EventSender::EventSender):
     10        (EventSender::gestureScrollBegin):
     11        (EventSender::gestureScrollEnd):
     12        (EventSender::gestureTap):
     13        (EventSender::gestureEvent):
     14        * DumpRenderTree/chromium/EventSender.h:
     15
    1162011-08-12  Andy Estes  <aestes@apple.com>
    217
  • trunk/Tools/DumpRenderTree/chromium/EventSender.cpp

    r92341 r92997  
    279279    bindMethod("touchStart", &EventSender::touchStart);
    280280    bindMethod("updateTouchPoint", &EventSender::updateTouchPoint);
     281    bindMethod("gestureScrollBegin", &EventSender::gestureScrollBegin);
     282    bindMethod("gestureScrollEnd", &EventSender::gestureScrollEnd);
     283    bindMethod("gestureTap", &EventSender::gestureTap);
    281284    bindMethod("zoomPageIn", &EventSender::zoomPageIn);
    282285    bindMethod("zoomPageOut", &EventSender::zoomPageOut);
     
    10191022}
    10201023
     1024void EventSender::gestureScrollBegin(const CppArgumentList& arguments, CppVariant* result)
     1025{
     1026    result->setNull();
     1027    gestureEvent(WebInputEvent::GestureScrollBegin, arguments);
     1028}
     1029
     1030void EventSender::gestureScrollEnd(const CppArgumentList& arguments, CppVariant* result)
     1031{
     1032    result->setNull();
     1033    gestureEvent(WebInputEvent::GestureScrollEnd, arguments);
     1034}
     1035
     1036void EventSender::gestureTap(const CppArgumentList& arguments, CppVariant* result)
     1037{
     1038    result->setNull();
     1039    gestureEvent(WebInputEvent::GestureTap, arguments);
     1040}
     1041
     1042void EventSender::gestureEvent(WebInputEvent::Type type, const CppArgumentList& arguments)
     1043{
     1044    if (arguments.size() < 2 || !arguments[0].isNumber() || !arguments[1].isNumber())
     1045        return;
     1046
     1047    WebPoint point(arguments[0].toInt32(), arguments[1].toInt32());
     1048
     1049    WebGestureEvent event;
     1050    event.type = type;
     1051    event.x = point.x;
     1052    event.y = point.y;
     1053    event.globalX = point.x;
     1054    event.globalY = point.y;
     1055    event.timeStampSeconds = getCurrentEventTimeSec();
     1056    webview()->handleInputEvent(event);
     1057}
     1058
    10211059//
    10221060// Unimplemented stubs
  • trunk/Tools/DumpRenderTree/chromium/EventSender.h

    r92341 r92997  
    9595    void updateTouchPoint(const CppArgumentList&, CppVariant*);
    9696
     97    void gestureScrollBegin(const CppArgumentList&, CppVariant*);
     98    void gestureScrollEnd(const CppArgumentList&, CppVariant*);
     99    void gestureTap(const CppArgumentList&, CppVariant*);
     100    void gestureEvent(WebKit::WebInputEvent::Type, const CppArgumentList&);
     101
    97102    // Unimplemented stubs
    98103    void contextClick(const CppArgumentList&, CppVariant*);
Note: See TracChangeset for help on using the changeset viewer.