Changeset 93150 in webkit

Timestamp:

Aug 16, 2011 1:44:51 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Unmatrix algorithm implementation is wrong
​https://bugs.webkit.org/show_bug.cgi?id=66080

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-08-16
Reviewed by Dean Jackson.

Source/WebCore:

Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.

Test: animations/animation-matrix-negative-scale-unmatrix.html

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose):

LayoutTests:

• animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
• animations/animation-matrix-negative-scale-unmatrix.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/animations/animation-matrix-negative-scale-unmatrix-expected.txt (added)
• LayoutTests/animations/animation-matrix-negative-scale-unmatrix.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-16  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        Unmatrix algorithm implementation is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=66080
+
+        Reviewed by Dean Jackson.
+
+        * animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
+        * animations/animation-matrix-negative-scale-unmatrix.html: Added.
+
 2011-08-16  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-16  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        Unmatrix algorithm implementation is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=66080
+
+        Reviewed by Dean Jackson.
+
+        Current version of the algorithm negates only the scaleX while
+        it should negate also scaleY and scaleZ when appropriate.
+
+        Test: animations/animation-matrix-negative-scale-unmatrix.html
+
+        * platform/graphics/transforms/TransformationMatrix.cpp:
+        (WebCore::decompose):
+
 2011-08-16  Joseph Pecoraro  <joepeck@webkit.org>
 

trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp

@@ -396 +396 @@
     v3Cross(row[1], row[2], pdum3);
     if (v3Dot(row[0], pdum3) < 0) {
+
+        result.scaleX *= -1;
+        result.scaleY *= -1;
+        result.scaleZ *= -1;
+
         for (i = 0; i < 3; i++) {
-            result.scaleX *= -1;
             row[i][0] *= -1;
             row[i][1] *= -1;