Changeset 93241 in webkit
- Timestamp:
- Aug 17, 2011 2:13:29 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js
r93224 r93241 92 92 var title = item.getElementsByTagName('title')[0].textContent; 93 93 var author = item.getElementsByTagName('author')[0].textContent; 94 var time = item.getElementsByTagName('pubDate')[0].textContent; 94 95 95 96 // FIXME: This isn't a very high-fidelity reproduction of the commit message, … … 102 103 'revision': findRevision(title), 103 104 'title': title, 105 'time': time, 104 106 'summary': findSummary(message), 105 107 'author': findAuthor(message) || author, -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js
r93063 r93241 159 159 "revision": 92259, 160 160 "title": "Revision 92259: Unreviewed, rolling out r92256.\nhttp://trac.webkit.org/changeset/92256 ...", 161 "time": "Wed, 03 Aug 2011 04:26:52 GMT", 161 162 "summary": "Unreviewed, rolling out r92256.", 162 163 "author": "Sheriff Bot", … … 167 168 "revision": 92256, 168 169 "title": "Revision 92256: Support cast between CSSPrimitiveValue and EBoxSizing, use in ...", 170 "time": "Thu, 04 Aug 2011 02:09:19 GMT", 169 171 "summary": "Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.", 170 172 "author": "macpherson@chromium.org", -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
r93163 r93241 36 36 push: function(notification) 37 37 { 38 // FIXME: Add in descending time order. 38 39 this.insertBefore(notification, this.firstChild); 39 40 return notification; … … 68 69 init: function() 69 70 { 70 this. updateTime(new Date());71 this.date = new Date(); 71 72 }, 72 updateTime: function(time)73 date: function() 73 74 { 74 this.textContent = base.relativizeTime(time); 75 return this._date; 76 }, 77 setDate: function(date) 78 { 79 this._date = date; 80 this.textContent = base.relativizeTime(date); 75 81 } 76 82 }); … … 134 140 if (this.containsFailureAnalysis(failureAnalysis)) 135 141 return; 136 // FIXME: Retrieve date from failureAnalysis and set this._time.137 // FIXME: Add in order by time.138 142 return this._tests.appendChild(new ui.notifications.FailingTest(failureAnalysis)); 139 143 }, 140 144 addCommitData: function(commitData) 141 145 { 146 var commitDataDate = new Date(commitData.time); 147 if (this._time.date > commitDataDate); 148 this._time.date = commitDataDate; 142 149 return this._causes.appendChild(new ui.notifications.SuspiciousCommit(commitData)); 143 150 } -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
r93163 r93241 71 71 testFailures.addFailureAnalysis({testName: 'test'}); 72 72 equal(testFailures.innerHTML, '<time>Just now</time><div class="what"><div class="problem"><ul class="effects"><li>test</li></ul><ul class="causes"></ul></div></div>'); 73 testFailures.addCommitData({revision: 1, title: "title", author: "author", reviewer: "reviewer"}); 74 equal(testFailures.innerHTML, '<time>Just now</time><div class="what"><div class="problem"><ul class="effects"><li>test</li></ul><ul class="causes"><li><div class="description"><a href="">1</a>title author (reviewer)</div><ul class="actions"><li><button>Roll out</button></li></ul></li></ul></div></div>'); 73 var time = new Date(); 74 time.setMinutes(time.getMinutes() - 10); 75 testFailures.addCommitData({revision: 1, time: time, title: "title", author: "author", reviewer: "reviewer"}); 76 equal(testFailures.innerHTML, '<time>10 minutes ago</time><div class="what"><div class="problem"><ul class="effects"><li>test</li></ul><ul class="causes"><li><div class="description"><a href="">1</a>title author (reviewer)</div><ul class="actions"><li><button>Roll out</button></li></ul></li></ul></div></div>'); 75 77 }); 76 78 -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js
r93224 r93241 242 242 "revision": 92342, 243 243 "title": "Revision 92342: Support cast between CSSPrimitiveValue and EBoxSizing, use in ...", 244 "time": "Thu, 04 Aug 2011 02:09:19 GMT", 244 245 "summary": "Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.", 245 246 "author": "macpherson@chromium.org", … … 250 251 "revision": 92341, 251 252 "title": "Revision 92341: Implement EventSender.scalePageBy() ...", 253 "time": "Thu, 04 Aug 2011 02:01:31 GMT", 252 254 "summary": "Implement EventSender.scalePageBy()", 253 255 "author": "Kentaro Hara", … … 258 260 "revision": 92338, 259 261 "title": "Revision 92338: Revert an erroneous rebaseline from r92315.\n* ...", 262 "time": "Thu, 04 Aug 2011 01:41:29 GMT", 260 263 "summary": "Revert an erroneous rebaseline from r92315.", 261 264 "author": "rniwa@webkit.org", … … 266 269 "revision": 92337, 267 270 "title": "Revision 92337: [Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html ...", 271 "time": "Thu, 04 Aug 2011 00:22:21 GMT", 268 272 "summary": "[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn't show composited content", 269 273 "author": "noam.rosenthal@nokia.com", … … 274 278 "revision": 92259, 275 279 "title": "Revision 92259: Unreviewed, rolling out r92256.\nhttp://trac.webkit.org/changeset/92256 ...", 280 "time": "Wed, 03 Aug 2011 04:26:52 GMT", 276 281 "summary": "Unreviewed, rolling out r92256.", 277 282 "author": "Sheriff Bot", -
trunk/Tools/ChangeLog
r93240 r93241 1 2011-08-16 Dimitri Glazkov <dglazkov@chromium.org> 2 3 Wire up relative time to garden-o-matic summary view. 4 https://bugs.webkit.org/show_bug.cgi?id=66343 5 6 Reviewed by Adam Barth. 7 8 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 9 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests. 10 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date. 11 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests. 12 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests. 13 1 14 2011-08-17 Adam Roben <aroben@apple.com> 2 15
Note: See TracChangeset
for help on using the changeset viewer.