Changeset 93382 in webkit


Ignore:
Timestamp:
Aug 18, 2011 6:33:07 PM (13 years ago)
Author:
tkent@chromium.org
Message:

REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
https://bugs.webkit.org/show_bug.cgi?id=66453

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/forms/placeholder-crash-with-scrollbar-corner.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.

LayoutTests:

  • fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
  • fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r93374 r93382  
     12011-08-18  Kent Tamura  <tkent@chromium.org>
     2
     3        REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
     4        https://bugs.webkit.org/show_bug.cgi?id=66453
     5
     6        Reviewed by Simon Fraser.
     7
     8        * fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
     9        * fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
     10
    1112011-08-18  Tony Chang  <tony@chromium.org>
    212
  • trunk/Source/WebCore/ChangeLog

    r93380 r93382  
     12011-08-18  Kent Tamura  <tkent@chromium.org>
     2
     3        REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner
     4        https://bugs.webkit.org/show_bug.cgi?id=66453
     5
     6        Reviewed by Simon Fraser.
     7
     8        Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
     9
     10        * rendering/RenderObjectChildList.cpp:
     11        (WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
     12
    1132011-08-18  Jeffrey Pfau  <jpfau@apple.com>
    214
  • trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

    r93307 r93382  
    8686        RenderLayer* layer = 0;
    8787        if (owner->style()->visibility() != VISIBLE && oldChild->style()->visibility() == VISIBLE && !oldChild->hasLayer()) {
    88             layer = owner->enclosingLayer();
    89             layer->dirtyVisibleContentStatus();
     88            if ((layer = owner->enclosingLayer()))
     89                layer->dirtyVisibleContentStatus();
    9090        }
    9191
Note: See TracChangeset for help on using the changeset viewer.