Changeset 93410 in webkit

Timestamp:

Aug 19, 2011 8:25:03 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
​https://bugs.webkit.org/show_bug.cgi?id=65408

Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-08-19
Reviewed by Adam Roben.

• ewk/ewk_frame.cpp:

(_ewk_frame_smart_add):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_frame.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-08-19  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Add "return" statement corresponding to abnormal condition on _ewk_frame_smart_add.
+        https://bugs.webkit.org/show_bug.cgi?id=65408
+
+        Bail out when we fail to allocate an Ewk_Frame_Smart_Data object rather than continuing on as if the allocation had succeeded.
+
+        Reviewed by Adam Roben.
+
+        * ewk/ewk_frame.cpp:
+        (_ewk_frame_smart_add):
+
 2011-08-19  KwangHyuk Kim  <hyuki.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

@@ -183 +183 @@
     if (!sd) {
         sd = (Ewk_Frame_Smart_Data*)calloc(1, sizeof(Ewk_Frame_Smart_Data));
-        if (!sd)
+        if (!sd) {
             CRITICAL("could not allocate Ewk_Frame_Smart_Data");
-        else
-            evas_object_smart_data_set(o, sd);
+            return;
+        }
+        evas_object_smart_data_set(o, sd);
     }