Changeset 93443 in webkit

Timestamp:

Aug 19, 2011 3:20:19 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
​https://bugs.webkit.org/show_bug.cgi?id=66499

Patch by Van Lam <​vanlam@google.com> on 2011-08-19
Reviewed by Ryosuke Niwa.

Renamed VisiblePosition::honorEditableBoundary* to
honorEditingBoundary.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):

• editing/VisiblePosition.h:
• editing/visible_units.cpp:

(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
(WebCore::logicalStartOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/VisiblePosition.cpp (modified) (5 diffs)
• editing/VisiblePosition.h (modified) (1 diff)
• editing/visible_units.cpp (modified) (10 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-19  Van Lam  <vanlam@google.com>
+
+        Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
+        https://bugs.webkit.org/show_bug.cgi?id=66499
+
+        Reviewed by Ryosuke Niwa.
+
+        Renamed VisiblePosition::honorEditableBoundary* to
+        honorEditingBoundary.
+
+        * editing/VisiblePosition.cpp:
+        (WebCore::VisiblePosition::next):
+        (WebCore::VisiblePosition::previous):
+        (WebCore::VisiblePosition::left):
+        (WebCore::VisiblePosition::right):
+        (WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
+        (WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
+        * editing/VisiblePosition.h:
+        * editing/visible_units.cpp:
+        (WebCore::previousWordPosition):
+        (WebCore::nextWordPosition):
+        (WebCore::startOfLine):
+        (WebCore::endOfLine):
+        (WebCore::previousSentencePosition):
+        (WebCore::nextSentencePosition):
+        (WebCore::logicalStartOfLine):
+        (WebCore::logicalEndOfLine):
+        (WebCore::leftWordPosition):
+        (WebCore::rightWordPosition):
+
 2011-08-19  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/editing/VisiblePosition.cpp

@@ -71 +71 @@
         return next;
 
-    return honorEditableBoundaryAtOrAfter(next);
+    return honorEditingBoundaryAtOrAfter(next);
 }
 
@@ -101 +101 @@
         return prev;
     
-    return honorEditableBoundaryAtOrBefore(prev);
+    return honorEditingBoundaryAtOrBefore(prev);
 }
 
@@ -252 +252 @@
 
     // FIXME: This may need to do something different from "before".
-    return honorEditableBoundaryAtOrBefore(left);
+    return honorEditingBoundaryAtOrBefore(left);
 }
 
@@ -404 +404 @@
 
     // FIXME: This may need to do something different from "after".
-    return honorEditableBoundaryAtOrAfter(right);
-}
-
-VisiblePosition VisiblePosition::honorEditableBoundaryAtOrBefore(const VisiblePosition &pos) const
+    return honorEditingBoundaryAtOrAfter(right);
+}
+
+VisiblePosition VisiblePosition::honorEditingBoundaryAtOrBefore(const VisiblePosition &pos) const
 {
     if (pos.isNull())
@@ -433 +433 @@
 }
 
-VisiblePosition VisiblePosition::honorEditableBoundaryAtOrAfter(const VisiblePosition &pos) const
+VisiblePosition VisiblePosition::honorEditingBoundaryAtOrAfter(const VisiblePosition &pos) const
 {
     if (pos.isNull())

trunk/Source/WebCore/editing/VisiblePosition.h

@@ -71 +71 @@
     VisiblePosition next(EditingBoundaryCrossingRule = CanCrossEditingBoundary) const;
     VisiblePosition previous(EditingBoundaryCrossingRule = CanCrossEditingBoundary) const;
-    VisiblePosition honorEditableBoundaryAtOrBefore(const VisiblePosition&) const;
-    VisiblePosition honorEditableBoundaryAtOrAfter(const VisiblePosition&) const;
+    VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&) const;
+    VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&) const;
 
     VisiblePosition left(bool stayInEditableContent = false) const;

trunk/Source/WebCore/editing/visible_units.cpp

@@ -293 +293 @@
 {
     VisiblePosition prev = previousBoundary(c, previousWordPositionBoundary);
-    return c.honorEditableBoundaryAtOrBefore(prev);
+    return c.honorEditingBoundaryAtOrBefore(prev);
 }
 
@@ -309 +309 @@
 {
     VisiblePosition next = nextBoundary(c, nextWordPositionBoundary);    
-    return c.honorEditableBoundaryAtOrAfter(next);
+    return c.honorEditingBoundaryAtOrAfter(next);
 }
 
@@ -374 +374 @@
     VisiblePosition visPos = startPositionForLine(c);
 
-    return c.honorEditableBoundaryAtOrBefore(visPos);
+    return c.honorEditingBoundaryAtOrBefore(visPos);
 }
 
@@ -443 +443 @@
     }
     
-    return c.honorEditableBoundaryAtOrAfter(visPos);
+    return c.honorEditingBoundaryAtOrAfter(visPos);
 }
 
@@ -706 +706 @@
 {
     VisiblePosition prev = previousBoundary(c, previousSentencePositionBoundary);
-    return c.honorEditableBoundaryAtOrBefore(prev);
+    return c.honorEditingBoundaryAtOrBefore(prev);
 }
 
@@ -720 +720 @@
 {
     VisiblePosition next = nextBoundary(c, nextSentencePositionBoundary);    
-    return c.honorEditableBoundaryAtOrAfter(next);
+    return c.honorEditingBoundaryAtOrAfter(next);
 }
 
@@ -1068 +1068 @@
             return firstPositionInNode(editableRoot);
     }
-    return c.honorEditableBoundaryAtOrBefore(visPos);
+    return c.honorEditingBoundaryAtOrBefore(visPos);
 }
 
@@ -1131 +1131 @@
             return lastPositionInNode(editableRoot);
     }
-    return c.honorEditableBoundaryAtOrAfter(visPos);
+    return c.honorEditingBoundaryAtOrAfter(visPos);
 }
 
@@ -1680 +1680 @@
 
     VisiblePosition leftWordBreak = leftWordPositionIgnoringEditingBoundary(visiblePosition);
-    return visiblePosition.honorEditableBoundaryAtOrBefore(leftWordBreak);
+    return visiblePosition.honorEditingBoundaryAtOrBefore(leftWordBreak);
 }
 
@@ -1689 +1689 @@
 
     VisiblePosition rightWordBreak = rightWordPositionIgnoringEditingBoundary(visiblePosition);
-    return visiblePosition.honorEditableBoundaryAtOrBefore(rightWordBreak);
-}
-
-}
+    return visiblePosition.honorEditingBoundaryAtOrBefore(rightWordBreak);
+}
+
+}