Changeset 93452 in webkit


Ignore:
Timestamp:
Aug 19, 2011 4:37:05 PM (13 years ago)
Author:
jpfau@apple.com
Message:

libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Reviewed by Darin Adler.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Reviewed by Darin Adler.

  • fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r93448 r93452  
     12011-08-19  Jeffrey Pfau  <jpfau@apple.com>
     2
     3        libxml2 fragment parser loses prefix namespaces
     4        https://bugs.webkit.org/show_bug.cgi?id=66423
     5
     6        Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
     7
     8        Reviewed by Darin Adler.
     9
     10        * fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
     11        * platform/chromium/test_expectations.txt:
     12        * platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
     13        * platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
     14
    1152011-08-19  Tony Chang  <tony@chromium.org>
    216
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r93448 r93452  
    35693569BUGWK64675 LINUX WIN : svg/custom/zero-path-square-cap-rendering.svg = IMAGE+TEXT
    35703570
     3571// New test added for bug 66423, needs rebaselining
     3572BUGWK66423 : fast/parser/innerhtml-with-prefixed-elements.xhtml = FAIL
     3573
    35713574// WebKit roll 80564:80631: rendering on Leopard is shifted to the top right
    35723575// started at some point at or after WK r80582 (Dave Hyatt's vertical text change - a very likely candidate)
  • trunk/Source/WebCore/ChangeLog

    r93445 r93452  
     12011-08-19  Jeffrey Pfau  <jpfau@apple.com>
     2
     3        libxml2 fragment parser loses prefix namespaces
     4        https://bugs.webkit.org/show_bug.cgi?id=66423
     5
     6        This makes the loop over the elements outside of the context actually update the element it's processing.
     7
     8        Reviewed by Darin Adler.
     9
     10        Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
     11
     12        * xml/parser/XMLDocumentParserLibxml2.cpp:
     13        (WebCore::XMLDocumentParser::XMLDocumentParser):
     14
    1152011-08-19  Beth Dakin  <bdakin@apple.com>
    216
  • trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

    r91008 r93452  
    611611        return;
    612612
    613     for (Element* element = elemStack.last(); !elemStack.isEmpty(); elemStack.removeLast()) {
     613    for (; !elemStack.isEmpty(); elemStack.removeLast()) {
     614        Element* element = elemStack.last();
    614615        if (NamedNodeMap* attrs = element->attributes()) {
    615616            for (unsigned i = 0; i < attrs->length(); i++) {
Note: See TracChangeset for help on using the changeset viewer.