Changeset 93463 in webkit


Ignore:
Timestamp:
Aug 19, 2011 6:31:11 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

[chromium] Default to experimental-fully-parallel mode for chromium gpu port
https://bugs.webkit.org/show_bug.cgi?id=66606

Patch by James Robinson <jamesr@chromium.org> on 2011-08-19
Reviewed by Dirk Pranke.

The chromium GPU configuration does not (currently) contain any tests
incompatible with --experimental-fully-parallel, and this flag is a
significan speedup because of the directory canvas/philip/tests which
contains 802 tests in the same directory. Setting this option by
default on this configuration is a 2x speed in release, 44s to 22s,
and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r93451 r93463  
     12011-08-19  James Robinson  <jamesr@chromium.org>
     2
     3        [chromium] Default to experimental-fully-parallel mode for chromium gpu port
     4        https://bugs.webkit.org/show_bug.cgi?id=66606
     5
     6        Reviewed by Dirk Pranke.
     7
     8        The chromium GPU configuration does not (currently) contain any tests
     9        incompatible with --experimental-fully-parallel, and this flag is a
     10        significan speedup because of the directory canvas/philip/tests which
     11        contains 802 tests in the same directory. Setting this option by
     12        default on this configuration is a 2x speed in release, 44s to 22s,
     13        and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
     14
     15        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
     16        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
     17        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
     18
    1192011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
    220
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py

    r93444 r93463  
    6666    if port.get_option('accelerated_2d_canvas') is None:
    6767        port._options.accelerated_2d_canvas = True
     68    if port.get_option('experimental_fully_parallel') is None:
     69        port._options.experimental_fully_parallel = True
    6870
    6971    # FIXME: Remove this after http://codereview.chromium.org/5133001/ is enabled
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py

    r93444 r93463  
    6868        self.assertTrue(port._options.accelerated_compositing)
    6969        self.assertTrue(port._options.accelerated_2d_canvas)
     70        self.assertTrue(port._options.experimental_fully_parallel)
    7071        self.assertEqual(port._options.builder_name, 'foo - GPU')
    7172
  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

    r92803 r93463  
    378378                                "'inline' and 'processes'.")),
    379379        optparse.make_option("-f", "--experimental-fully-parallel",
    380             action="store_true", default=False,
     380            action="store_true",
    381381            help="run all tests in parallel"),
     382        optparse.make_option("--no-experimental-fully-parallel",
     383            action="store_false",
     384            dest="experimental_fully_parallel",
     385            help="do not run all tests in parallel"),
    382386        optparse.make_option("--exit-after-n-failures", type="int", default=500,
    383387            help="Exit after the first N failures instead of running all "
Note: See TracChangeset for help on using the changeset viewer.