Changeset 93523 in webkit

Timestamp:

Aug 22, 2011 11:18:59 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Content and render surface textures not freed when compositor context destroyed
​https://bugs.webkit.org/show_bug.cgi?id=66589

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

Explicitly delete all managed textures when destroying the compositor
context. This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.

We sadly don't have a way to construct automated tests for resource
leaks currently.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::cleanupSharedObjects):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/LayerRendererChromium.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-22  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Content and render surface textures not freed when compositor context destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=66589
+
+        Reviewed by Kenneth Russell.
+
+        Explicitly delete all managed textures when destroying the compositor
+        context.  This regressed due to a combination of using share groups
+        (so destroying a context no longer implicitly releases all resources
+        in that context) and switching the TextureManager over to support
+        deferred texture destruction.
+
+        We sadly don't have a way to construct automated tests for resource
+        leaks currently.
+
+        * platform/graphics/chromium/LayerRendererChromium.cpp:
+        (WebCore::LayerRendererChromium::cleanupSharedObjects):
+
 2011-08-22  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp

@@ -1284 +1284 @@
 
     // Clear tilers before the texture manager, as they have references to textures.
+    m_contentsTextureManager->unprotectAllTextures();
+    m_contentsTextureManager->reduceMemoryToLimit(0);
+    m_contentsTextureManager->deleteEvictedTextures(m_context.get());
     m_contentsTextureManager.clear();
+    m_renderSurfaceTextureManager->unprotectAllTextures();
+    m_renderSurfaceTextureManager->reduceMemoryToLimit(0);
+    m_renderSurfaceTextureManager->deleteEvictedTextures(m_context.get());
     m_renderSurfaceTextureManager.clear();
 }