Changeset 93620 in webkit


Ignore:
Timestamp:
Aug 23, 2011 11:46:33 AM (13 years ago)
Author:
jocelyn.turcotte@nokia.com
Message:

[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.

  • UIProcess/qt/SGAgent.h:

(WebKit::NodeUpdate::~NodeUpdate):

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r93594 r93620  
     12011-08-23  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
     2
     3        [Qt][WK2] Fix an awful memory leak introduced in r92376.
     4        https://bugs.webkit.org/show_bug.cgi?id=65528
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        The non-virtual destructor would create a leak of the tile update buffer because
     9        the NodeUpdateSetTexture's QImage member destructor wouldn't be called.
     10
     11        * UIProcess/qt/SGAgent.h:
     12        (WebKit::NodeUpdate::~NodeUpdate):
     13
    1142011-08-23  Steve Block  <steveblock@google.com>
    215
  • trunk/Source/WebKit2/UIProcess/qt/SGAgent.h

    r92376 r93620  
    6767        : type(type)
    6868    { }
     69    virtual ~NodeUpdate() { }
    6970    Type type;
    7071};
Note: See TracChangeset for help on using the changeset viewer.