Changeset 93623 in webkit


Ignore:
Timestamp:
Aug 23, 2011 12:27:32 PM (13 years ago)
Author:
Patrick Gansterer
Message:

webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Reviewed by Adam Roben.

Use the string form of pipe open instead (like we do at all other places).

  • Scripts/VCSUtils.pm:

(mergeChangeLogs):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r93607 r93623  
     12011-08-23  Patrick Gansterer  <paroga@webkit.org>
     2
     3        webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
     4        https://bugs.webkit.org/show_bug.cgi?id=49080
     5
     6        Reviewed by Adam Roben.
     7
     8        Use the string form of pipe open instead (like we do at all other places).
     9
     10        * Scripts/VCSUtils.pm:
     11        (mergeChangeLogs):
     12
    1132011-08-23  Adam Barth  <abarth@webkit.org>
    214
  • trunk/Tools/Scripts/VCSUtils.pm

    r89196 r93623  
    16971697        rename($fileOlder, "$fileOlder.save");
    16981698    } else {
    1699         open(DIFF, "-|", qw(diff -u -a --binary), $fileOlder, $fileMine) or die $!;
     1699        open(DIFF, "diff -u -a --binary \"$fileOlder\" \"$fileMine\" |") or die $!;
    17001700        $patch = <DIFF>;
    17011701        close(DIFF);
Note: See TracChangeset for help on using the changeset viewer.