Changeset 93641 in webkit


Ignore:
Timestamp:
Aug 23, 2011 3:10:26 PM (13 years ago)
Author:
Dimitri Glazkov
Message:

garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js

    r93607 r93641  
    308308    return function(delta) {
    309309        var deltaInUnits = delta / divisorInMilliseconds;
    310         return (deltaInUnits).toFixed(0) + ' ' + unit + (deltaInUnits >= 2 ? 's' : '') + ' ago';
     310        return (deltaInUnits).toFixed(0) + ' ' + unit + (deltaInUnits >= 1.5 ? 's' : '') + ' ago';
    311311    }
    312312}
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js

    r93607 r93641  
    381381});
    382382
    383 test("relativizeTime", 11, function() {
     383test("relativizeTime", 14, function() {
    384384    var time = new Date();
    385385    equals(base.relativizeTime(time), "Just now");
     
    394394    time.setMinutes(time.getMinutes() - 1);
    395395    equals(base.relativizeTime(time), "1 hour ago");
     396    time.setMinutes(time.getMinutes() - 29);
     397    equals(base.relativizeTime(time), "1 hour ago");
     398    time.setMinutes(time.getMinutes() - 2);
     399    equals(base.relativizeTime(time), "2 hours ago");
     400    time.setMinutes(time.getMinutes() - 29);
     401    equals(base.relativizeTime(time), "2 hours ago");
    396402    time.setHours(time.getHours() - 1);
    397     equals(base.relativizeTime(time), "2 hours ago");
    398     time.setHours(time.getHours() - 21);
     403    equals(base.relativizeTime(time), "3 hours ago");
     404    time.setHours(time.getHours() - 20);
    399405    equals(base.relativizeTime(time), "23 hours ago");
    400406    time.setHours(time.getHours() - 1);
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

    r93522 r93641  
    6868var kTenMinutesInMilliseconds = 10 * 60 * 1000;
    6969config.kUpdateFrequency = kTenMinutesInMilliseconds;
    70 config.kRelativeTimeUpdateFrequency = 1000;
     70config.kRelativeTimeUpdateFrequency = 1000 * 60;
    7171
    7272
  • trunk/Tools/ChangeLog

    r93630 r93641  
     12011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        garden-o-matic relative time is wrong and updates too frequently.
     4        https://bugs.webkit.org/show_bug.cgi?id=66802
     5
     6        Reviewed by Adam Barth.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
     11
    1122011-08-23  Patrick Gansterer  <paroga@webkit.org>
    213
Note: See TracChangeset for help on using the changeset viewer.