Changeset 93658 in webkit


Ignore:
Timestamp:
Aug 23, 2011 4:33:57 PM (13 years ago)
Author:
Dimitri Glazkov
Message:

Change garden-o-matic frontend builder array to be a configuration map.
​https://bugs.webkit.org/show_bug.cgi?id=66816

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js

    r93259 r93658  
    8484{
    8585    var buildInfoByBuilder = {};
    86     var requestTracker = new base.RequestTracker(config.kBuilders.length, callback, [buildInfoByBuilder]);
     86    var builderNames = Object.keys(config.kBuilders);
     87    var requestTracker = new base.RequestTracker(builderNames.length, callback, [buildInfoByBuilder]);
    8788    net.get(kChromiumBuildBotURL + '/json/builders', function(builderStatus) {
    88         $.each(config.kBuilders, function(index, builderName) {
     89        $.each(builderNames, function(index, builderName) {
    8990            var buildNumber = mostRecentCompletedBuildNumber(builderStatus[builderName]);
    9091            if (!buildNumber) {

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

    r93641 r93658  
    2828(function() {
    2929
    30 config.kBuilders = [
    31     'Webkit Win',
    32     'Webkit Vista',
    33     'Webkit Win7',
    34     'Webkit Win (dbg)(1)',
    35     'Webkit Win (dbg)(2)',
    36     'Webkit Linux',
    37     'Webkit Linux 32',
    38     'Webkit Linux (dbg)(1)',
    39     'Webkit Linux (dbg)(2)',
    40     'Webkit Mac10.5 (CG)',
    41     'Webkit Mac10.5 (CG)(dbg)(1)',
    42     'Webkit Mac10.5 (CG)(dbg)(2)',
    43     'Webkit Mac10.6 (CG)',
    44     'Webkit Mac10.6 (CG)(dbg)',
    45 ];
     30config.kBuilders = {
     31    'Webkit Win': {version: 'xp'},
     32    'Webkit Vista': {version: 'vista'},
     33    'Webkit Win7': {version: 'win7'},
     34    'Webkit Win (dbg)(1)': {version: 'xp', debug: true},
     35    'Webkit Win (dbg)(2)': {version: 'xp', debug: true},
     36    'Webkit Linux': {version: 'lucid', is64bit: true},
     37    'Webkit Linux 32': {version: 'lucid'},
     38    'Webkit Linux (dbg)(1)': {version: 'lucid', is64bit: true, debug: true},
     39    'Webkit Linux (dbg)(2)': {version: 'lucid', is64bit: true, debug: true},
     40    'Webkit Mac10.5 (CG)': {version: 'leopard'},
     41    'Webkit Mac10.5 (CG)(dbg)(1)': {version: 'leopard', debug: true},
     42    'Webkit Mac10.5 (CG)(dbg)(2)': {version: 'leopard', debug: true},
     43    'Webkit Mac10.6 (CG)': {version: 'snowleopard'},
     44    'Webkit Mac10.6 (CG)(dbg)': {version: 'snowleopard', debug: true},
     45};
    4646
    4747config.kBuildersThatOnlyCompile = [

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js

    r93259 r93658  
    246246{
    247247    $.each(model.state.resultsByBuilder, function(builderName, resultsTree) {
    248         var builderIndex = config.kBuilders.indexOf(builderName);
     248        var builderIndex = Object.keys(config.kBuilders).indexOf(builderName);
    249249        rowsBeforeRevision(resultsTree.revision).each(function() {
    250250            $($(this).children()[builderIndex]).addClass('built');

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js

    r93259 r93658  
    132132model.updateResultsByBuilder = function(callback)
    133133{
    134     results.fetchResultsByBuilder(config.kBuilders, function(resultsByBuilder) {
     134    results.fetchResultsByBuilder(Object.keys(config.kBuilders), function(resultsByBuilder) {
    135135        model.state.resultsByBuilder = resultsByBuilder;
    136136        callback();

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

    r93522 r93658  
    9090    var list = [];
    9191
    92     $.each(config.kBuilders, function(index, builderName) {
     92    $.each(Object.keys(config.kBuilders), function(index, builderName) {
    9393        var block = $('<td class="builder"></td>');
    9494        block.attr('title', ui.displayNameForBuilder(builderName));

  • trunk/Tools/ChangeLog

    r93653 r93658  
     12011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        Change garden-o-matic frontend builder array to be a configuration map.
     4        https://bugs.webkit.org/show_bug.cgi?id=66816
     5
     6        Reviewed by Adam Barth.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
     13
    1142011-08-23  Cary Clark  <caryclark@google.com>
    215
Note: See TracChangeset for help on using the changeset viewer.