Changeset 93685 in webkit

Timestamp:

Aug 23, 2011 6:55:25 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Get the default value for `scripts_window_open' from the right method.
​https://bugs.webkit.org/show_bug.cgi?id=66775

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

For some unknown reason, the default value for this setting was being
obtained from Settings::allowScriptsToCloseWindows() instead of
Settings::javaScriptCanOpenWindowsAutomatically(), which makes no
sense at all.

• ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-08-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Get the default value for `scripts_window_open' from the right method.
+        https://bugs.webkit.org/show_bug.cgi?id=66775
+
+        Reviewed by Kent Tamura.
+
+        For some unknown reason, the default value for this setting was being
+        obtained from Settings::allowScriptsToCloseWindows() instead of
+        Settings::javaScriptCanOpenWindowsAutomatically(), which makes no
+        sense at all.
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+
 2011-08-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -634 +634 @@
     priv->settings.enable_plugins = priv->page_settings->arePluginsEnabled();
     priv->settings.enable_frame_flattening = priv->page_settings->frameFlatteningEnabled();
-    priv->settings.scripts_window_open = priv->page_settings->allowScriptsToCloseWindows();
+    priv->settings.scripts_window_open = priv->page_settings->javaScriptCanOpenWindowsAutomatically();
     priv->settings.resizable_textareas = priv->page_settings->textAreasAreResizable();
     priv->settings.private_browsing = priv->page_settings->privateBrowsingEnabled();