Changeset 93689 in webkit

Timestamp:

Aug 23, 2011 7:11:11 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Make WebGL context current before querying for extensions
​https://bugs.webkit.org/show_bug.cgi?id=66788

We're making changes on the Chromium side for threaded compositing that
will require makeContextCurrent to be called on the appropriate thread
before any other GL calls.

In line with other GraphicsContext3D implementations, we do this
implicitly. This is the minimum change that makes WebGL compliant.

Patch by Iain Merrick <​husky@google.com> on 2011-08-23
Reviewed by Kenneth Russell.

• src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DInternal::initializeExtensions):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/GraphicsContext3DChromium.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-08-23  Iain Merrick  <husky@google.com>
+
+        [chromium] Make WebGL context current before querying for extensions
+        https://bugs.webkit.org/show_bug.cgi?id=66788
+
+        We're making changes on the Chromium side for threaded compositing that
+        will require makeContextCurrent to be called on the appropriate thread
+        before any other GL calls.
+
+        In line with other GraphicsContext3D implementations, we do this
+        implicitly. This is the minimum change that makes WebGL compliant.
+
+        Reviewed by Kenneth Russell.
+
+        * src/GraphicsContext3DChromium.cpp:
+        (WebCore::GraphicsContext3DInternal::initializeExtensions):
+
 2011-08-23  Scott Byer  <scottbyer@chromium.org>
 

trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp

@@ -790 +790 @@
 void GraphicsContext3DInternal::initializeExtensions()
 {
-    if (!m_initializedAvailableExtensions) {
+    bool success = makeContextCurrent();
+    ASSERT(success);
+    if (success && !m_initializedAvailableExtensions) {
         String extensionsString = getString(GraphicsContext3D::EXTENSIONS);
         splitStringHelper(extensionsString, m_enabledExtensions);