Changeset 93691 in webkit

Timestamp:

Aug 23, 2011 9:24:08 PM (13 years ago)

Author:

Dimitri Glazkov

Message:

Make notifications appear in time order again.
​https://bugs.webkit.org/show_bug.cgi?id=66815

Reviewed by Adam Barth.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

@@ -161 +161 @@
     {
         var commitDataDate = new Date(commitData.time);
-        if (this._time.date > commitDataDate);
+        if (this._time.date > commitDataDate); {
+            this.setIndex(commitDataDate.getTime());
             this._time.setDate(commitDataDate);
+        }
         return this._causes.appendChild(new ui.notifications.SuspiciousCommit(commitData));
     }

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

@@ -91 +91 @@
 });
 
-test('TestFailures', 8, function() {
+test('TestFailures', 10, function() {
     var testFailures = new ui.notifications.TestFailures();
     equal(testFailures.tagName, 'LI');
@@ -106 +106 @@
         '</ul>');
     testFailures.addFailureAnalysis({testName: 'test'});
+    equal(testFailures.index(), 0);
     equal(testFailures.innerHTML,
         '<time class="relative">Just now</time>' +
@@ -139 +140 @@
     time.setMinutes(time.getMinutes() - 10);
     testFailures.addCommitData({revision: 1, time: time, title: "title", author: "author", reviewer: "reviewer"});
+    equal(testFailures.index(), time.getTime());
     equal(testFailures.innerHTML,
         '<time class="relative">10 minutes ago</time>' +

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Make notifications appear in time order again.
+        https://bugs.webkit.org/show_bug.cgi?id=66815
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
+
 2011-08-23  James Robinson  <jamesr@chromium.org>