Changeset 93693 in webkit

Timestamp:

Aug 23, 2011 9:37:44 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Change parameter type for some APIs in ewk_tile_matrix.
​https://bugs.webkit.org/show_bug.cgi?id=66639

As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch
are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now
using unsigned long type for both col and row parameter, row parameter for ewk_tile_matrix
is also better to be specified as unsigned long type.

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2011-08-23
Reviewed by Anders Carlsson.

• ewk/ewk_tiled_matrix.c:

(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_exact_exists):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_update):
(ewk_tile_matrix_tile_update_full):

• ewk/ewk_tiled_matrix.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_tiled_matrix.c (modified) (5 diffs)
• ewk/ewk_tiled_matrix.h (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-08-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Change parameter type for some APIs in ewk_tile_matrix.
+        https://bugs.webkit.org/show_bug.cgi?id=66639
+
+        As type of both col and row parameter for ewk_tile_matrix's some APIs listed by this patch
+        are different from each other and eina_matrixsparse associated with ewk_tile_matrix is now
+        using unsigned long type for both col and row parameter, row parameter for ewk_tile_matrix
+        is also better to be specified as unsigned long type.
+
+        Reviewed by Anders Carlsson.
+
+        * ewk/ewk_tiled_matrix.c:
+        (ewk_tile_matrix_tile_exact_get):
+        (ewk_tile_matrix_tile_exact_exists):
+        (ewk_tile_matrix_tile_new):
+        (ewk_tile_matrix_tile_update):
+        (ewk_tile_matrix_tile_update_full):
+        * ewk/ewk_tiled_matrix.h:
+
 2011-08-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
 

trunk/Source/WebKit/efl/ewk/ewk_tiled_matrix.c

@@ -270 +270 @@
  * @see ewk_tile_matrix_tile_exact_get()
  */
-Ewk_Tile *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom)
+Ewk_Tile *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, float zoom)
 {
     Ewk_Tile *t;
@@ -301 +301 @@
  * @see ewk_tile_matrix_tile_exact_get()
  */
-Eina_Bool ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom)
+Eina_Bool ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, float zoom)
 {
     Ewk_Tile *t;
@@ -324 +324 @@
  * @param zoom the level to create tile, used to determine tile size.
  */
-Ewk_Tile *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix *tm, Evas *evas, unsigned long col, unsigned int row, float zoom)
+Ewk_Tile *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix *tm, Evas *evas, unsigned long col, unsigned long row, float zoom)
 {
     Evas_Coord tw, th;
@@ -394 +394 @@
 }
 
-Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, const Eina_Rectangle *update)
+Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, const Eina_Rectangle *update)
 {
     Ewk_Tile *t;
@@ -425 +425 @@
 }
 
-Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row)
+Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row)
 {
     Ewk_Tile *t;

trunk/Source/WebKit/efl/ewk/ewk_tiled_matrix.h

@@ -34 +34 @@
 Ewk_Tile_Unused_Cache *ewk_tile_matrix_unused_cache_get(const Ewk_Tile_Matrix *tm);
 
-Ewk_Tile *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-Eina_Bool ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-Ewk_Tile *ewk_tile_matrix_tile_nearest_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, float zoom);
-Ewk_Tile *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix *tm, Evas *evas, unsigned long col, unsigned int row, float zoom);
+Ewk_Tile *ewk_tile_matrix_tile_exact_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, float zoom);
+Eina_Bool ewk_tile_matrix_tile_exact_exists(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, float zoom);
+Ewk_Tile *ewk_tile_matrix_tile_nearest_get(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, float zoom);
+Ewk_Tile *ewk_tile_matrix_tile_new(Ewk_Tile_Matrix *tm, Evas *evas, unsigned long col, unsigned long row, float zoom);
 Eina_Bool ewk_tile_matrix_tile_put(Ewk_Tile_Matrix *tm, Ewk_Tile *t, double last_used);
 
-Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row, const Eina_Rectangle *update);
-Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix *tm, unsigned long col, unsigned int row);
+Eina_Bool ewk_tile_matrix_tile_update(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row, const Eina_Rectangle *update);
+Eina_Bool ewk_tile_matrix_tile_update_full(Ewk_Tile_Matrix *tm, unsigned long col, unsigned long row);
 void ewk_tile_matrix_tile_updates_clear(Ewk_Tile_Matrix *tm, Ewk_Tile *t);