Changeset 93751 in webkit

Timestamp:

Aug 24, 2011 6:02:02 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Stacktrace not in test output when a test crashes
​https://bugs.webkit.org/show_bug.cgi?id=66806

Patch by James Robinson <​jamesr@chromium.org> on 2011-08-24
Reviewed by Dirk Pranke.

Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
trace.

• Scripts/webkitpy/layout_tests/port/chromium.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-24  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Stacktrace not in test output when a test crashes
+        https://bugs.webkit.org/show_bug.cgi?id=66806
+
+        Reviewed by Dirk Pranke.
+
+        Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
+        trace.
+
+        * Scripts/webkitpy/layout_tests/port/chromium.py:
+
 2011-08-24  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py

@@ -577 +577 @@
                 text = None
 
+        error = ''.join(error)
+        # Currently the stacktrace is in the text output, not error, so append the two together so
+        # that we can see stack in the output. See http://webkit.org/b/66806
+        # FIXME: We really should properly handle the stderr output separately.
+        if crash:
+            error = error + str(text)
+
         return DriverOutput(text, output_image, actual_checksum, audio=audio_bytes,
-            crash=crash, test_time=run_time, timeout=timeout, error=''.join(error))
+            crash=crash, test_time=run_time, timeout=timeout, error=error)
 
     def stop(self):