Changeset 93764 in webkit


Ignore:
Timestamp:
Aug 25, 2011 1:13:20 AM (13 years ago)
Author:
morrita@google.com
Message:

Unreviewed, rolling out r93762.
​http://trac.webkit.org/changeset/93762
​https://bugs.webkit.org/show_bug.cgi?id=66756

IndexedDb tests crash

Source/WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/generic/EventConstructors.h: Removed.
  • bindings/v8/OptionsObject.cpp:
  • bindings/v8/OptionsObject.h:
  • bindings/v8/custom/V8EventConstructors.cpp: Removed.
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/Event.idl:

LayoutTests:

  • fast/events/event-constructors-expected.txt: Removed.
  • fast/events/event-constructors.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
Location:
trunk
Files:
4 deleted
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r93763 r93764  
     12011-08-25  MORITA Hajime  <morrita@google.com>
     2
     3        Unreviewed, rolling out r93762.
     4        http://trac.webkit.org/changeset/93762
     5        https://bugs.webkit.org/show_bug.cgi?id=66756
     6
     7        IndexedDb tests crash
     8
     9        * fast/events/event-constructors-expected.txt: Removed.
     10        * fast/events/event-constructors.html: Removed.
     11        * platform/gtk/Skipped:
     12        * platform/mac/Skipped:
     13        * platform/qt/Skipped:
     14        * platform/win/Skipped:
     15        * platform/wk2/Skipped:
     16
    1172011-08-25  Zoltan Herczeg  <zherczeg@webkit.org>
    218

  • trunk/LayoutTests/platform/gtk/Skipped

    r93762 r93764  
    492492fast/forms/select-script-onchange.html
    493493fast/html/tab-order.html
    494 
    495 # These tests require the implementation of Event constructors.
    496 # https://bugs.webkit.org/show_bug.cgi?id=63878
    497 fast/events/event-constructors.html
    498494
    499495# The box isn't empty after a test run with this test.

  • trunk/LayoutTests/platform/mac/Skipped

    r93762 r93764  
    8989fast/events/mouseover-button.html
    9090
    91 # These tests require the JSC implementation of Event constructors.
    92 # https://bugs.webkit.org/show_bug.cgi?id=63878
    93 fast/events/event-constructors.html
    94 
    9591# Skipped until https://bugs.webkit.org/show_bug.cgi?id=33923 is resolved.
    9692platform/mac/accessibility/change-notification-on-scroll.html

  • trunk/LayoutTests/platform/qt/Skipped

    r93762 r93764  
    202202# Font feature settings is not implemented.
    203203css3/font-feature-settings-rendering.html
    204 
    205 # These tests require the JSC implementation of Event constructors.
    206 # https://bugs.webkit.org/show_bug.cgi?id=63878
    207 fast/events/event-constructors.html
    208204
    209205# =========================================================================== #

  • trunk/LayoutTests/platform/win/Skipped

    r93762 r93764  
    148148# No button tracked
    149149fast/events/mouseover-button.html
    150 
    151 # These tests require the JSC implementation of Event constructors.
    152 # https://bugs.webkit.org/show_bug.cgi?id=63878
    153 fast/events/event-constructors.html
    154150
    155151# The eqqivalent of option-tab doesn not exist in Boomer <rdar://problem/5137230>

  • trunk/LayoutTests/platform/wk2/Skipped

    r93762 r93764  
    15961596platform/mac/fast/text/rounding-hacks-expansion.html
    15971597
    1598 # These tests require the implementation of Event constructors.
    1599 # https://bugs.webkit.org/show_bug.cgi?id=63878
    1600 fast/events/event-constructors.html
    1601 
    16021598# Sometimes fails
    16031599# http://webkit.org/b/58990

  • trunk/Source/WebCore/ChangeLog

    r93762 r93764  
     12011-08-25  MORITA Hajime  <morrita@google.com>
     2
     3        Unreviewed, rolling out r93762.
     4        http://trac.webkit.org/changeset/93762
     5        https://bugs.webkit.org/show_bug.cgi?id=66756
     6
     7        IndexedDb tests crash
     8
     9        * WebCore.gypi:
     10        * WebCore.pro:
     11        * bindings/generic/EventConstructors.h: Removed.
     12        * bindings/v8/OptionsObject.cpp:
     13        * bindings/v8/OptionsObject.h:
     14        * bindings/v8/custom/V8EventConstructors.cpp: Removed.
     15        * dom/Event.cpp:
     16        * dom/Event.h:
     17        (WebCore::Event::create):
     18        * dom/Event.idl:
     19
    1202011-08-24  Kentaro Hara  <haraken@google.com>
    221

  • trunk/Source/WebCore/WebCore.gypi

    r93762 r93764  
    17301730            'bindings/generic/BindingSecurityBase.cpp',
    17311731            'bindings/generic/BindingSecurityBase.h',
    1732             'bindings/generic/EventConstructors.h',
    17331732            'bindings/generic/GenericBinding.h',
    17341733            'bindings/generic/RuntimeEnabledFeatures.cpp',
    … …  
    21432142            'bindings/v8/custom/V8EntryCustom.cpp',
    21442143            'bindings/v8/custom/V8EntrySyncCustom.cpp',
    2145             'bindings/v8/custom/V8EventConstructors.cpp',
    21462144            'bindings/v8/custom/V8EventCustom.cpp',
    21472145            'bindings/v8/custom/V8EventSourceConstructor.cpp',

  • trunk/Source/WebCore/WebCore.pro

    r93762 r93764  
    165165        bindings/v8/custom/V8DocumentLocationCustom.cpp \
    166166        bindings/v8/custom/V8ElementCustom.cpp \
    167         bindings/v8/custom/V8EventConstructors.cpp \
    168167        bindings/v8/custom/V8EventCustom.cpp \
    169168        bindings/v8/custom/V8EventSourceConstructor.cpp \

  • trunk/Source/WebCore/bindings/v8/OptionsObject.cpp

    r93762 r93764  
    9090}
    9191
    92 bool OptionsObject::getKeyDouble(const String& key, double& value) const
    93 {
    94     v8::Local<v8::Value> v8Value;
    95     if (!getKey(key, v8Value))
    96         return false;
    97 
    98     v8::Local<v8::Number> v8Number = v8Value->ToNumber();
    99     if (v8Number.IsEmpty())
    100         return false;
    101     value = v8Number->Value();
    102     return true;
    103 }
    104 
    10592bool OptionsObject::getKeyString(const String& key, String& value) const
    10693{

  • trunk/Source/WebCore/bindings/v8/OptionsObject.h

    r93762 r93764  
    4848    bool getKeyString(const String& key, String& value) const;
    4949    bool getKeyStringWithUndefinedOrNullCheck(const String& key, String& value) const;
    50     bool getKeyDouble(const String& key, double& value) const;
    5150    PassRefPtr<DOMStringList> getKeyDOMStringList(const String& key) const;
    5251    PassRefPtr<IDBKeyRange> getKeyKeyRange(const String& key) const;
    53 
    54      bool getKeyValue(const String& key, bool& value) const
    55      {
    56          return getKeyBool(key, value);
    57      }
    58      bool getKeyValue(const String& key, int32_t& value) const
    59      {
    60          return getKeyInt32(key, value);
    61      }
    62      bool getKeyValue(const String& key, double& value) const
    63      {
    64          return getKeyDouble(key, value);
    65      }
    66      bool getKeyValue(const String& key, String& value) const
    67      {
    68          return getKeyString(key, value);
    69      }
    7052
    7153private:

  • trunk/Source/WebCore/dom/Event.cpp

    r93762 r93764  
    3232namespace WebCore {
    3333
    34 EventConfiguration::EventConfiguration()
    35     : bubbles(false)
    36     , cancelable(false)
    37     , defaultPrevented(false)
    38     , timeStamp(0)
    39 {
    40 }
    41 
    4234Event::Event()
    4335    : m_canBubble(false)
    … …  
    6961}
    7062
    71 Event::Event(const AtomicString& eventType, const EventConfiguration& eventConfiguration)
    72     : m_type(eventType)
    73     , m_canBubble(eventConfiguration.bubbles)
    74     , m_cancelable(eventConfiguration.cancelable)
    75     , m_propagationStopped(false)
    76     , m_immediatePropagationStopped(false)
    77     , m_defaultPrevented(eventConfiguration.defaultPrevented)
    78     , m_defaultHandled(false)
    79     , m_cancelBubble(false)
    80     , m_eventPhase(0)
    81     , m_currentTarget(0)
    82     , m_createTime(static_cast<DOMTimeStamp>(eventConfiguration.timeStamp))
    83 {
    84 }
    85 
    8663Event::~Event()
    8764{

  • trunk/Source/WebCore/dom/Event.h

    r93762 r93764  
    3434    class EventTarget;
    3535    class EventDispatcher;
    36 
    37     struct EventConfiguration {
    38         EventConfiguration();
    39 
    40         bool bubbles;
    41         bool cancelable;
    42         bool defaultPrevented;
    43         double timeStamp;
    44     };
    4536
    4637    class Event : public RefCounted<Event> {
    … …  
    7869        {
    7970            return adoptRef(new Event(type, canBubble, cancelable));
    80         }
    81         static PassRefPtr<Event> create(const AtomicString& type, const EventConfiguration& eventConfiguration)
    82         {
    83             return adoptRef(new Event(type, eventConfiguration));
    8471        }
    8572        virtual ~Event();
    … …  
    190177        Event();
    191178        Event(const AtomicString& type, bool canBubble, bool cancelable);
    192         Event(const AtomicString&, const EventConfiguration&);
    193179
    194180        virtual void receivedTarget();

  • trunk/Source/WebCore/dom/Event.idl

    r93762 r93764  
    11/*
    2  * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
     2 * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
    33 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
    44 *
    … …  
    2525        CustomToJS,
    2626        NoStaticTables,
    27         Polymorphic,
    28         CanBeConstructed,
    29         V8CustomConstructor
     27        Polymorphic
    3028    ] Event {
    3129
Note: See TracChangeset for help on using the changeset viewer.