Changeset 93926 in webkit

Timestamp:

Aug 26, 2011 5:23:11 PM (13 years ago)

Author:

Dimitri Glazkov

Message:

garden-o-matic summary view should have pretty commit data information.
​https://bugs.webkit.org/show_bug.cgi?id=67069

Reviewed by Adam Barth.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (modified) (4 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

@@ -110 +110 @@
     {
         var linkToRevision = this._description.appendChild(document.createElement('a'));
-        // FIXME: Set href.
-        linkToRevision.href = '';
+        linkToRevision.href = trac.changesetURL(commitData.revision);
+        linkToRevision.target = '_blank';
         linkToRevision.textContent = commitData.revision;
-        // FIXME: Reviewer could be unknown.
-        // FIXME: Provide opportunities to style title/author/reviewer separately.
-        this._description.appendChild(document.createTextNode(commitData.title + ' ' + commitData.author + ' (' + commitData.reviewer + ')'));
+        this._addDescriptionPart('title', commitData);
+        this._addDescriptionPart('author', commitData);
+        this._addDescriptionPart('reviewer', commitData);
+    },
+    _addDescriptionPart: function(part, commitData)
+    {
+        var content = commitData[part];
+        if (!content)
+            return;
+
+        var span = this._description.appendChild(document.createElement('span'));
+        span.className = part;
+        span.textContent = content;
     }
 });

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

@@ -88 +88 @@
     var suspiciousCommit = new ui.notifications.SuspiciousCommit({revision: 1, title: "title", author: "author", reviewer: "reviewer"});
     equal(suspiciousCommit.tagName, 'LI');
-    equal(suspiciousCommit.innerHTML, '<div class="description"><a href="">1</a>title author (reviewer)</div><ul class="actions"><li><button>Roll out</button></li></ul>');
+    equal(suspiciousCommit.innerHTML,
+        '<div class="description">' +
+            '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
+            '<span class="title">title</span>' +
+            '<span class="author">author</span>' +
+            '<span class="reviewer">reviewer</span>' +
+        '</div>' +
+        '<ul class="actions">' +
+            '<li><button>Roll out</button></li>' +
+        '</ul>');
 });
 
@@ -187 +196 @@
                 '<li>' +
                     '<div class="description">' +
-                        '<a href="">1</a>title author (reviewer)'+
+                        '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
+                        '<span class="title">title</span>' +
+                        '<span class="author">author</span>' +
+                        '<span class="reviewer">reviewer</span>' +
                     '</div>' +
                     '<ul class="actions">' +
@@ -224 +236 @@
                 '<li>' +
                     '<div class="description">' +
-                        '<a href="">1</a>title author (reviewer)'+
+                        '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
+                        '<span class="title">title</span>' +
+                        '<span class="author">author</span>' +
+                        '<span class="reviewer">reviewer</span>' +
                     '</div>' +
                     '<ul class="actions">' +
@@ -266 +281 @@
                 '<li>' +
                     '<div class="description">' +
-                        '<a href="">1</a>title author (reviewer)'+
+                        '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' +
+                        '<span class="title">title</span>' +
+                        '<span class="author">author</span>' +
+                        '<span class="reviewer">reviewer</span>' +
                     '</div>' +
                     '<ul class="actions">' +

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css

@@ -27 +27 @@
  font-family: 'Open Sans';
  font-size: 14px;
+}
+
+a {
+    color: #333;
 }
 

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css

@@ -73 +73 @@
 ol.notifications ul.causes>li {
     border-top: 1px solid LightGray;
-    padding: 10px;
+    padding: 10px 20px 10px 0;
 }
 
@@ -79 +79 @@
         padding: 0 10px 0 0;
     }
+
+        ol.notifications>li ul.causes>li>div.description>a {
+            padding: 0 20px 0 10px;
+            border-radius: 4px;
+        }
+
+        ol.notifications>li ul.causes>li:hover>div.description>a {
+            background-color: #555;
+            padding: 5px 10px 5px 10px;
+            margin: 0 10px 0 0;
+            color: White;
+        }
+
+        ol.notifications>li ul.causes>li:hover>div.description>a::after {
+            content: '';
+            width: 0;
+            height: 0;
+            margin-top: 5px;
+            position: absolute;
+            margin-left: 10px;
+            border-top: 5px solid White;
+            border-left: 5px solid #555;
+            border-bottom: 5px solid White;
+        }
+
+        ol.notifications>li ul.causes>li>div.description>span {
+            padding: 0 10px 0 0;
+            display: inline-block;
+        }
+
+        ol.notifications>li ul.causes>li>div.description>span.reviewer {
+            color: Gray;
+        }
+
+        ol.notifications>li ul.causes>li>div.description>span.reviewer::before {
+            content: '(';
+        }
+
+        ol.notifications>li ul.causes>li>div.description>span.reviewer::after {
+            content: ')';
+        }
 
     ol.notifications>li ul.causes>li>ul.actions {

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        garden-o-matic summary view should have pretty commit data information.
+        https://bugs.webkit.org/show_bug.cgi?id=67069
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
+
 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>