Changeset 94200 in webkit


Ignore:
Timestamp:
Aug 31, 2011 10:30:46 AM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic results view shouldn't be horrifically ugly
​https://bugs.webkit.org/show_bug.cgi?id=67264

Reviewed by Dimitri Glazkov.

Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

    r94198 r94200  
    3939        this._view.addAction(new ui.actions.Previous());
    4040        this._view.addAction(new ui.actions.Next());
    41         this._view.addAction(new ui.actions.Close());
    4241
    4342        $(this._view).bind('testselected', this.onTestSelected.bind(this));
    4443        $(this._view).bind('builderselected', this.onBuilderSelected.bind(this));
    4544        $(this._view).bind('rebaseline', this.onRebaseline.bind(this));
    46         $(this._view).bind('close', this.onClose.bind(this));
    4745    },
    4846    _failureInfoForTestAndBuilder: function(testName, builderName)
    … …  
    5351            'failureTypeList': results.failureTypeList(this._resultsByTest[testName][builderName].actual)
    5452        }
    55     },
    56     dismiss: function()
    57     {
    58         $(this._view).detach();
    5953    },
    6054    showTest: function(testName)
    … …  
    8074        });
    8175    },
    82     onClose: function() {
    83         this.dismiss();
    84     }
    8576});
    8677

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js

    r93758 r94200  
    228228    {
    229229        this.className = 'results-view';
    230         this.innerHTML = '<div class="toolbar"><div class="selector"></div></div><div class="content"></div>';
     230        this.innerHTML = '<div class="toolbar"></div><div class="content"></div>';
    231231
    232232        this._testSelector = new ui.results.TestSelector();
    … …  
    235235        this._actionList = new ui.actions.List();
    236236
    237         $('.toolbar', this).prepend(this._actionList);
    238         $('.selector', this).append(this._testSelector).append(this._builderSelector);
     237        $('.toolbar', this).append(this._testSelector).append(this._builderSelector).append(this._actionList);
    239238        $('.content', this).append(this._resultsDetails);
    240239    },

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css

    r93847 r94200  
    3535}
    3636
    37 .results-view {
    38     background-color: #f5f5f5;
     37.results-view table th {
     38    padding: 3px;
     39    border-bottom: 1px solid #AAA;
    3940}
    4041
    4142.results-view .toolbar {
    42     border-top: 1px solid #c6c6c6;
    43     border-bottom: 1px solid #c6c6c6;
    44 }
    45 
    46 .results-view .toolbar .selector {
    47     font-size: 11px;
    48     font-weight: bold;
    49     height: 29px;
    50     line-height: 27px;
    51     margin: 11px 6px;
    52     padding: 0 8px;
     43    padding-bottom: 15px;
    5344}
    5445
    … …  
    5849}
    5950
    60 .results-view .toolbar .actions {
     51.results-view .actions {
    6152    float: right;
    6253}
    … …  
    7364}
    7465
    75 .results-view td {
    76     background-color: white;
    77 }
    78 
    7966.results-view .text-result {
    8067    border: none;

  • trunk/Tools/ChangeLog

    r94198 r94200  
     12011-08-31  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic results view shouldn't be horrifically ugly
     4        https://bugs.webkit.org/show_bug.cgi?id=67264
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
     9
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
     13
    1142011-08-31  Adam Barth  <abarth@webkit.org>
    215
Note: See TracChangeset for help on using the changeset viewer.