Changeset 94623 in webkit
- Timestamp:
- Sep 6, 2011 7:05:02 PM (13 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r94622 r94623 1 2011-09-06 Filip Pizlo <fpizlo@apple.com> 2 3 Accessibility tests crashing in BasicRawSentinelNode code 4 https://bugs.webkit.org/show_bug.cgi?id=67682 5 6 Reviewed by Geoffrey Garen. 7 8 A CodeBlock should ensure that no other CodeBlocks have references to it after 9 it is destroyed. 10 11 * bytecode/CodeBlock.cpp: 12 (JSC::CodeBlock::~CodeBlock): 13 1 14 2011-09-06 Yong Li <yoli@rim.com> 2 15 -
trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp
r94616 r94623 1449 1449 #endif 1450 1450 1451 // We should not be garbage collected if there are incoming calls. But 1452 // if this is called during heap destruction, then there may still be 1453 // incoming calls, which is harmless. 1451 // We may be destroyed before any CodeBlocks that refer to us are destroyed. 1452 // Consider that two CodeBlocks become unreachable at the same time. There 1453 // is no guarantee about the order in which the CodeBlocks are destroyed. 1454 // So, if we don't remove incoming calls, and get destroyed before the 1455 // CodeBlock(s) that have calls into us, then the CallLinkInfo vector's 1456 // destructor will try to remove nodes from our (no longer valid) linked list. 1457 while (m_incomingCalls.begin() != m_incomingCalls.end()) 1458 m_incomingCalls.begin()->remove(); 1454 1459 1455 1460 // Note that our outgoing calls will be removed from other CodeBlocks'
Note: See TracChangeset
for help on using the changeset viewer.