Changeset 94696 in webkit


Ignore:
Timestamp:
Sep 7, 2011 12:14:30 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by David Hyatt.

Fixed the test to properly attach load event listener on window instead of document.

Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.

  • css2.1/t090204-display-change-01-b-ao.html:
  • fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
  • platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
  • platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
Location:
trunk/LayoutTests
Files:
4 edited
1 copied

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r94695 r94696  
     12011-09-07  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
     4        https://bugs.webkit.org/show_bug.cgi?id=67725
     5
     6        Reviewed by David Hyatt.
     7
     8        Fixed the test to properly attach load event listener on window instead of document.
     9
     10        Since this broken test also caught a bug fixed in r94693, I made a copy of this version in fast/css.
     11
     12        * css2.1/t090204-display-change-01-b-ao.html:
     13        * fast/css/line-after-floating-div.html: Copied from LayoutTests/css2.1/t090204-display-change-01-b-ao.html.
     14        * platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
     15        * platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
     16
    1172011-09-03  Robert Hogan  <robert@webkit.org>
    218
  • trunk/LayoutTests/css2.1/t090204-display-change-01-b-ao.html

    r18637 r94696  
    88        document.getElementById('float').style.display = 'none';
    99      }
    10       document.addEventListener("load", test, false);
     10      window.addEventListener("load", test, false);
    1111    </script>
    1212    <style>
  • trunk/LayoutTests/fast/css/line-after-floating-div.html

    r94692 r94696  
    44    <title>CSS 2.1 Test Suite: Updating layout on display changes</title>
    55    <link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#display-prop">
    6     <script type="text/javascript">
    7       function test() {
    8         document.getElementById('float').style.display = 'none';
    9       }
    10       document.addEventListener("load", test, false);
    11     </script>
    126    <style>
    137      #float { width: 100%; float:left; }
  • trunk/LayoutTests/platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt

    r25970 r94696  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x90
    4   RenderBlock {HTML} at (0,0) size 800x90
    5     RenderBody {BODY} at (8,16) size 784x66
     3layer at (0,0) size 800x74
     4  RenderBlock {HTML} at (0,0) size 800x74
     5    RenderBody {BODY} at (8,16) size 784x50
    66      RenderBlock {P} at (0,0) size 784x18
    77        RenderText {#text} at (0,0) size 268x18
    88          text run at (0,0) width 268: "There should be no red below, only green."
    9       RenderBlock (floating) {DIV} at (0,34) size 784x16 [color=#008000] [bgcolor=#FF0000]
     9      RenderBlock {DIV} at (0,34) size 16x16 [color=#008000] [bgcolor=#FF0000]
    1010        RenderText {#text} at (0,0) size 16x16
    1111          text run at (0,0) width 16: "X"
    12       RenderBlock {DIV} at (0,34) size 16x32 [color=#008000] [bgcolor=#FF0000]
    13         RenderText {#text} at (0,16) size 16x16
    14           text run at (0,16) width 16: "X"
Note: See TracChangeset for help on using the changeset viewer.