Changeset 94749 in webkit

Timestamp:

Sep 8, 2011 1:55:43 AM (13 years ago)

Author:

caseq@chromium.org

Message:

2011-09-07 Andrey Kosyakov <​caseq@chromium.org>

Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
​https://bugs.webkit.org/show_bug.cgi?id=67715

Reviewed by Yury Semikhatsky.

• avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.

• inspector/front-end/TextViewer.js: (WebInspector.TextViewer.forwardWheelEvent): (WebInspector.TextViewer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextViewer.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-07  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
+        https://bugs.webkit.org/show_bug.cgi?id=67715
+
+        Reviewed by Yury Semikhatsky.
+
+        - avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.
+
+        * inspector/front-end/TextViewer.js:
+        (WebInspector.TextViewer.forwardWheelEvent):
+        (WebInspector.TextViewer):
+
 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/TextViewer.js

@@ -52 +52 @@
 
     // Forward mouse wheel events from the unscrollable gutter to the main panel.
-    this._gutterPanel.element.addEventListener("mousewheel", function(e) {
-        this._mainPanel.element.dispatchEvent(e);
-    }.bind(this), false);
+    function forwardWheelEvent(event)
+    {
+        var clone = document.createEvent("WheelEvent");
+        clone.initWebKitWheelEvent(event.wheelDeltaX, event.wheelDeltaY,
+                                   event.view,
+                                   event.screenX, event.screenY,
+                                   event.clientX, event.clientY,
+                                   event.ctrlKey, event.altKey, event.shiftKey, event.metaKey);
+        this._mainPanel.element.dispatchEvent(clone);
+    }
+    this._gutterPanel.element.addEventListener("mousewheel", forwardWheelEvent.bind(this), false);
 
     this.element.addEventListener("dblclick", this._doubleClick.bind(this), true);