Changeset 94774 in webkit


Ignore:
Timestamp:
Sep 8, 2011 11:41:55 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Oliver Hunt.

We don't use JSCell::getUInt32 anymore, so it has been removed.

Location:
trunk/Source/JavaScriptCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r94731 r94774  
     12011-09-08  Mark Hahnenberg  <mhahnenberg@apple.com>
     2
     3        Remove getUInt32 from JSCell
     4        https://bugs.webkit.org/show_bug.cgi?id=67691
     5
     6        Reviewed by Oliver Hunt.
     7
     8         We don't use JSCell::getUInt32 anymore, so it has been removed.
     9
     10        * JavaScriptCore.exp:
     11        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
     12        * runtime/JSCell.cpp:
     13        * runtime/JSCell.h:
     14
    1152011-09-07  Filip Pizlo  <fpizlo@apple.com>
    216
  • trunk/Source/JavaScriptCore/JavaScriptCore.exp

    r94701 r94774  
    548548__ZNK3JSC6JSCell9getStringEPNS_9ExecStateE
    549549__ZNK3JSC6JSCell9getStringEPNS_9ExecStateERNS_7UStringE
    550 __ZNK3JSC6JSCell9getUInt32ERj
    551550__ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE
    552551__ZNK3JSC7ArgList8getSliceEiRS0_
  • trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

    r94701 r94774  
    213213    ?getString@JSCell@JSC@@QBE?AVUString@2@PAVExecState@2@@Z
    214214    ?getString@JSCell@JSC@@QBE_NPAVExecState@2@AAVUString@2@@Z
    215     ?getUInt32@JSCell@JSC@@UBE_NAAI@Z
    216215    ?getter@PropertyDescriptor@JSC@@QBE?AVJSValue@2@XZ
    217216    ?globalExec@JSGlobalObject@JSC@@QAEPAVExecState@2@XZ
  • trunk/Source/JavaScriptCore/runtime/JSCell.cpp

    r92233 r94774  
    3030
    3131namespace JSC {
    32 
    33 bool JSCell::getUInt32(uint32_t&) const
    34 {
    35     return false;
    36 }
    3732
    3833bool JSCell::getString(ExecState* exec, UString&stringValue) const
  • trunk/Source/JavaScriptCore/runtime/JSCell.h

    r93835 r94774  
    104104        virtual ConstructType getConstructData(ConstructData&);
    105105
    106         // Extracting integer values.
    107         // FIXME: remove these methods, can check isNumberCell in JSValue && then call asNumberCell::*.
    108         virtual bool getUInt32(uint32_t&) const;
    109 
    110106        // Basic conversions.
    111107        virtual JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
Note: See TracChangeset for help on using the changeset viewer.