Changeset 94823 in webkit

Timestamp:

Sep 8, 2011 5:50:09 PM (13 years ago)

Author:

tony@chromium.org

Message:

Cleanup of switch statements with default cases
​https://bugs.webkit.org/show_bug.cgi?id=67808

Reviewed by Adam Barth.

No new tests, just a small refactoring.

• page/WebKitAnimation.cpp:

(WebCore::WebKitAnimation::fillMode):

• platform/audio/Distance.cpp:

(WebCore::DistanceEffect::gain):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/WebKitAnimation.cpp (modified) (1 diff)
• platform/audio/Distance.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-08  Tony Chang  <tony@chromium.org>
+
+        Cleanup of switch statements with default cases
+        https://bugs.webkit.org/show_bug.cgi?id=67808
+
+        Reviewed by Adam Barth.
+
+        No new tests, just a small refactoring.
+
+        * page/WebKitAnimation.cpp:
+        (WebCore::WebKitAnimation::fillMode):
+        * platform/audio/Distance.cpp:
+        (WebCore::DistanceEffect::gain):
+
 2011-09-08  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/page/WebKitAnimation.cpp

@@ -95 +95 @@
     case AnimationFillModeNone:
         return FILL_NONE;
-        break;
     case AnimationFillModeForwards:
         return FILL_FORWARDS;
-        break;
     case AnimationFillModeBackwards:
         return FILL_BACKWARDS;
-        break;
-    default:
+    case AnimationFillModeBoth:
         return FILL_BOTH;
-        break;
     }
+    ASSERT_NOT_REACHED();
+    return FILL_BOTH;
 }
 

trunk/Source/WebCore/platform/audio/Distance.cpp

@@ -61 +61 @@
     case ModelLinear:
         return linearGain(distance);
-        break;
     case ModelInverse:
         return inverseGain(distance);
-        break;
     case ModelExponential:
         return exponentialGain(distance);
-        break;
-
-    default:
-        return 0.0;
     }
+    ASSERT_NOT_REACHED();
+    return 0.0;
 }