Changeset 94838 in webkit


Ignore:
Timestamp:
Sep 9, 2011 12:14:01 AM (13 years ago)
Author:
simonjam@chromium.org
Message:

[Chromium] Fix leak of Skia stream with custom CSS fonts
​https://bugs.webkit.org/show_bug.cgi?id=67815

Reviewed by Adam Barth.

Test: fast/css/font-face-opentype.html under valgrind

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r94836 r94838  
     12011-09-09  James Simonsen  <simonjam@chromium.org>
     2
     3        [Chromium] Fix leak of Skia stream with custom CSS fonts
     4        https://bugs.webkit.org/show_bug.cgi?id=67815
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/css/font-face-opentype.html under valgrind
     9
     10        * platform/graphics/mac/FontCustomPlatformData.cpp:
     11        (WebCore::createFontCustomPlatformData):
     12        * platform/graphics/skia/FontCustomPlatformData.cpp:
     13        (WebCore::createFontCustomPlatformData):
     14
    1152011-09-07  Ryosuke Niwa  <rniwa@webkit.org>
    216

  • trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp

    r93781 r94838  
    164164    RemoteFontStream* stream = new RemoteFontStream(buffer);
    165165    fontCustomPlatformData->m_typeface = SkTypeface::CreateFromStream(stream);
     166    stream->unref();
    166167#endif
    167168    return fontCustomPlatformData;

  • trunk/Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp

    r94400 r94838  
    191191    RemoteFontStream* stream = new RemoteFontStream(buffer);
    192192    SkTypeface* typeface = SkTypeface::CreateFromStream(stream);
     193    stream->unref();
    193194    if (!typeface)
    194195        return 0;
Note: See TracChangeset for help on using the changeset viewer.