Changeset 94894 in webkit

Timestamp:

Sep 9, 2011 6:16:12 PM (13 years ago)

Author:

jchaffraix@webkit.org

Message:

[V8] V8WebKitPoint::constructorCallback leaks
​https://bugs.webkit.org/show_bug.cgi?id=67865

Reviewed by Adam Barth.

Covered by fast/js/instanceof-XMLHttpRequest.html under Valgrind.

• bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback): Changed the code
to use a RefPtr (per our usual style). Also use toV8 that will
take care of properly wrapping the object.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8WebKitPointConstructor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-09  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        [V8] V8WebKitPoint::constructorCallback leaks
+        https://bugs.webkit.org/show_bug.cgi?id=67865
+
+        Reviewed by Adam Barth.
+
+        Covered by fast/js/instanceof-XMLHttpRequest.html under Valgrind.
+
+        * bindings/v8/custom/V8WebKitPointConstructor.cpp:
+        (WebCore::V8WebKitPoint::constructorCallback): Changed the code
+        to use a RefPtr (per our usual style). Also use toV8 that will
+        take care of properly wrapping the object.
+
 2011-09-09  Chris Rogers  <crogers@google.com>
 

trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp

@@ -62 +62 @@
         }
     }
-    PassRefPtr<WebKitPoint> point = WebKitPoint::create(x, y);
-    point->ref();
+    RefPtr<WebKitPoint> point = WebKitPoint::create(x, y);
     V8DOMWrapper::setDOMWrapper(args.Holder(), &info, point.get());
-    return args.Holder();
+    return toV8(point.release(), args.Holder());
 }