Changeset 94957 in webkit

Timestamp:

Sep 12, 2011 8:22:32 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: event dividers do not update timeline boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=67932

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NetworkPanel.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-12  Pavel Feldman  <pfeldman@google.com>
+
+        Web Inspector: event dividers do not update timeline boundaries.
+        https://bugs.webkit.org/show_bug.cgi?id=67932
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkLogView.prototype._onLoadEventFired):
+        (WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
+        (WebInspector.NetworkLogView.prototype.refresh):
+        (WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):
+
 2011-09-12  Kentaro Hara  <haraken@google.com>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -628 +628 @@
     {
         this._mainResourceLoadTime = event.data || -1;
-        // Update the dividers to draw the new line
-        this._updateDividersIfNeeded(true);
+        // Schedule refresh to update boundaries and draw the new line.
+        this._scheduleRefresh(true);
     },
 
@@ -635 +635 @@
     {
         this._mainResourceDOMContentTime = event.data || -1;
-        this._updateDividersIfNeeded(true);
+        // Schedule refresh to update boundaries and draw the new line.
+        this._scheduleRefresh(true);
     },
 
@@ -662 +663 @@
         var staleItemsLength = this._staleResources.length;
         var boundariesChanged = false;
+        if (this.calculator.updateBoundariesForEventTime) {
+            boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceLoadTime) || boundariesChanged;
+            boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged;
+        }
 
         for (var i = 0; i < staleItemsLength; ++i) {
@@ -1669 +1674 @@
 
         return 0;
+    },
+
+    updateBoundariesForEventTime: function(eventTime)
+    {
+        if (eventTime === -1 || this.startAtZero)
+            return false;
+
+        if (typeof this.maximumBoundary === "undefined" || eventTime > this.maximumBoundary) {
+            this.maximumBoundary = eventTime;
+            return true;
+        }
+        return false;
     },