Changeset 94958 in webkit
- Timestamp:
- Sep 12, 2011 8:24:53 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r94953 r94958 1 2011-09-12 Pavel Feldman <pfeldman@google.com> 2 3 Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false. 4 https://bugs.webkit.org/show_bug.cgi?id=67934 5 6 Reviewed by Tony Gentilcore. 7 8 * inspector/runtime/runtime-setPropertyValue.html: 9 1 10 2011-09-12 Kentaro Hara <haraken@google.com> 2 11 -
trunk/LayoutTests/inspector/runtime/runtime-setPropertyValue-expected.txt
r92961 r94958 1 1 CONSOLE MESSAGE: line 11: ===== Initial ===== 2 2 CONSOLE MESSAGE: line 12: {"foo":1} 3 CONSOLE MESSAGE: line 13: {"bar":2} 4 CONSOLE MESSAGE: line 14: 3 CONSOLE MESSAGE: line 13: 5 4 CONSOLE MESSAGE: line 11: ===== Set primitive ===== 6 5 CONSOLE MESSAGE: line 12: {"foo":2} 7 CONSOLE MESSAGE: line 13: {"bar":2} 8 CONSOLE MESSAGE: line 14: 6 CONSOLE MESSAGE: line 13: 9 7 CONSOLE MESSAGE: line 11: ===== Set handle ===== 10 8 CONSOLE MESSAGE: line 12: {"foo":{"bar":2}} 11 CONSOLE MESSAGE: line 13: {"bar":2} 12 CONSOLE MESSAGE: line 14: 9 CONSOLE MESSAGE: line 13: 13 10 CONSOLE MESSAGE: line 11: ===== Set undefined ===== 14 11 CONSOLE MESSAGE: line 12: {} 15 CONSOLE MESSAGE: line 13: {"bar":2} 16 CONSOLE MESSAGE: line 14: 12 CONSOLE MESSAGE: line 13: 13 CONSOLE MESSAGE: line 11: ===== Set zero ===== 14 CONSOLE MESSAGE: line 12: {"foo":0} 15 CONSOLE MESSAGE: line 13: 16 CONSOLE MESSAGE: line 11: ===== Set null ===== 17 CONSOLE MESSAGE: line 12: {"foo":null} 18 CONSOLE MESSAGE: line 13: 19 CONSOLE MESSAGE: line 11: ===== Set empty string ===== 20 CONSOLE MESSAGE: line 12: {"foo":""} 21 CONSOLE MESSAGE: line 13: 17 22 CONSOLE MESSAGE: line 11: ===== Set exception ===== 18 CONSOLE MESSAGE: line 12: {} 19 CONSOLE MESSAGE: line 13: {"bar":2} 20 CONSOLE MESSAGE: line 14: 23 CONSOLE MESSAGE: line 12: {"foo":""} 24 CONSOLE MESSAGE: line 13: 21 25 Tests WebInspector.RemoveObject.setPropertyValue implementation. 22 26 … … 30 34 Running: testSetUndefined 31 35 36 Running: testSetZero 37 38 Running: testSetNull 39 40 Running: testSetEmptyString 41 32 42 Running: testSetException 33 43 { -
trunk/LayoutTests/inspector/runtime/runtime-setPropertyValue.html
r91754 r94958 7 7 var object2 = { bar: 2 }; 8 8 9 function dumpObject s(label)9 function dumpObject(label) 10 10 { 11 11 console.log("===== " + label + " ====="); 12 12 console.log(JSON.stringify(object1)); 13 console.log(JSON.stringify(object2));14 13 console.log(""); 15 14 } … … 22 21 function testSetUp(next) 23 22 { 24 InspectorTest.evaluateInPage("dumpObject s('Initial')", step0);23 InspectorTest.evaluateInPage("dumpObject('Initial')", step0); 25 24 26 25 function step0() … … 48 47 function step1() 49 48 { 50 InspectorTest.evaluateInPage("dumpObject s('Set primitive')", next);49 InspectorTest.evaluateInPage("dumpObject('Set primitive')", next); 51 50 } 52 51 }, … … 58 57 function step1() 59 58 { 60 InspectorTest.evaluateInPage("dumpObject s('Set handle')", next);59 InspectorTest.evaluateInPage("dumpObject('Set handle')", next); 61 60 } 62 61 }, … … 68 67 function step1() 69 68 { 70 InspectorTest.evaluateInPage("dumpObjects('Set undefined')", next); 69 InspectorTest.evaluateInPage("dumpObject('Set undefined')", next); 70 } 71 }, 72 73 function testSetZero(next) 74 { 75 obj1.setPropertyValue("foo", "0", step1); 76 77 function step1() 78 { 79 InspectorTest.evaluateInPage("dumpObject('Set zero')", next); 80 } 81 }, 82 83 function testSetNull(next) 84 { 85 obj1.setPropertyValue("foo", "null", step1); 86 87 function step1() 88 { 89 InspectorTest.evaluateInPage("dumpObject('Set null')", next); 90 } 91 }, 92 93 function testSetEmptyString(next) 94 { 95 obj1.setPropertyValue("foo", "\"\"", step1); 96 97 function step1() 98 { 99 InspectorTest.evaluateInPage("dumpObject('Set empty string')", next); 71 100 } 72 101 }, … … 79 108 { 80 109 InspectorTest.dump(error); 81 InspectorTest.evaluateInPage("dumpObject s('Set exception')", next);110 InspectorTest.evaluateInPage("dumpObject('Set exception')", next); 82 111 } 83 112 } -
trunk/Source/WebCore/ChangeLog
r94957 r94958 1 2011-09-12 Pavel Feldman <pfeldman@google.com> 2 3 Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false. 4 https://bugs.webkit.org/show_bug.cgi?id=67934 5 6 Reviewed by Tony Gentilcore. 7 8 * inspector/InjectedScriptSource.js: 9 1 10 2011-09-12 Pavel Feldman <pfeldman@google.com> 2 11 -
trunk/Source/WebCore/inspector/InjectedScriptSource.js
r93037 r94958 276 276 277 277 resolvedArgs.push(resolvedArg); 278 } else if ( args[i].value)278 } else if ("value" in args[i]) 279 279 resolvedArgs.push(args[i].value); 280 280 else
Note: See TracChangeset
for help on using the changeset viewer.