Changeset 94966 in webkit

Timestamp:

Sep 12, 2011 10:55:49 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Selectstart is not fired when selection was created by arrow keys.
​https://bugs.webkit.org/show_bug.cgi?id=60430

Patch by Arko Saha <​arko@motorola.com> on 2011-09-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fire selectstart when a user starts extending the selection using arrow key.
Fixed by Arko Saha <​arko@motorola.com> and Kaustubh Atrawalkar <Kaustubh Atrawalkar>

Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html

fast/events/selectstart-by-arrow-keys.html

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::dispatchSelectStart):

• editing/FrameSelection.h:

LayoutTests:

• fast/events/selectstart-by-arrow-keys-expected.txt: Added.
• fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added.
• fast/events/selectstart-by-arrow-keys-prevent-default.html: Added.
• fast/events/selectstart-by-arrow-keys.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/selectstart-by-arrow-keys-expected.txt (added)
• LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt (added)
• LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html (added)
• LayoutTests/fast/events/selectstart-by-arrow-keys.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/FrameSelection.cpp (modified) (2 diffs)
• Source/WebCore/editing/FrameSelection.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-12  Arko Saha  <arko@motorola.com>
+
+        Selectstart is not fired when selection was created by arrow keys.
+        https://bugs.webkit.org/show_bug.cgi?id=60430
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/events/selectstart-by-arrow-keys-expected.txt: Added.
+        * fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added.
+        * fast/events/selectstart-by-arrow-keys-prevent-default.html: Added.
+        * fast/events/selectstart-by-arrow-keys.html: Added.
+
 2011-09-12  Ben Wagner  <bungeman@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-12  Arko Saha  <arko@motorola.com>
+
+        Selectstart is not fired when selection was created by arrow keys.
+        https://bugs.webkit.org/show_bug.cgi?id=60430
+
+        Reviewed by Ryosuke Niwa.
+
+        Fire selectstart when a user starts extending the selection using arrow key.
+        Fixed by Arko Saha  <arko@motorola.com> and Kaustubh Atrawalkar  <kaustubh@motorola.com>
+
+        Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html
+               fast/events/selectstart-by-arrow-keys.html
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::modify):
+        (WebCore::FrameSelection::shouldChangeSelection):
+        (WebCore::FrameSelection::dispatchSelectStart):
+        * editing/FrameSelection.h:
+
 2011-09-12  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -825 +825 @@
         if (!change)
             return false;
+
+        if (trialFrameSelection.selection().isRange() && m_selection.isCaret() && !dispatchSelectStart())
+            return false;
     }
 
@@ -1885 +1888 @@
 }
 
+bool FrameSelection::dispatchSelectStart()
+{
+    Node* selectStartTarget = m_selection.extent().containerNode();
+    if (!selectStartTarget)
+        return true;
+
+    return selectStartTarget->dispatchEvent(Event::create(eventNames().selectstartEvent, true, true));
+}
+
 #ifndef NDEBUG
 

trunk/Source/WebCore/editing/FrameSelection.h

@@ -276 +276 @@
     void setCaretVisibility(CaretVisibility);
 
+    bool dispatchSelectStart();
+
     Frame* m_frame;