Changeset 94984 in webkit


Ignore:
Timestamp:
Sep 12, 2011 3:43:00 PM (13 years ago)
Author:
crogers@google.com
Message:

Address lifetime issues in OfflineAudioDestinationNode
​https://bugs.webkit.org/show_bug.cgi?id=67949

Reviewed by Kenneth Russell.

No new tests. This does not change JavaScript API.

  • webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r94982 r94984  
     12011-09-12  Chris Rogers  <crogers@google.com>
     2
     3        Address lifetime issues in OfflineAudioDestinationNode
     4        https://bugs.webkit.org/show_bug.cgi?id=67949
     5
     6        Reviewed by Kenneth Russell.
     7
     8        No new tests.  This does not change JavaScript API.
     9
     10        * webaudio/OfflineAudioDestinationNode.cpp:
     11        (WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
     12        (WebCore::OfflineAudioDestinationNode::render):
     13        (WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
     14
    1152011-09-12  Jeff Timanus  <twiz@chromium.org>
    216

  • trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

    r92068 r94984  
    5353OfflineAudioDestinationNode::~OfflineAudioDestinationNode()
    5454{
     55    if (m_renderThread)
     56        waitForThreadCompletion(m_renderThread, 0);
     57   
    5558    uninitialize();
    5659}
    … …  
    144147   
    145148    // Our work is done. Let the AudioContext know.
     149    // See corresponding deref() call in notifyCompleteDispatch().
     150    ref();
    146151    callOnMainThread(notifyCompleteDispatch, this);
    147152}
    … …  
    155160
    156161    destinationNode->notifyComplete();
     162    destinationNode->deref();
    157163}
    158164
Note: See TracChangeset for help on using the changeset viewer.