Changeset 95004 in webkit

Timestamp:

Sep 12, 2011 8:24:33 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
​https://bugs.webkit.org/show_bug.cgi?id=67038

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.

Since most of the time it will return the same thing as text(), we
initialize it the same way we initialize m_text. The other case (what
would have been generated if no modifiers were pressed) should be
covered by this as well.

As this method is used when handling access keys, tests such as
fast/events/access-key-self-destruct.html should now pass.

No new tests, as this fixes a problem uncovered by the existing ones.

• platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/efl/PlatformKeyboardEventEfl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
+        https://bugs.webkit.org/show_bug.cgi?id=67038
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Since most of the time it will return the same thing as text(), we
+        initialize it the same way we initialize m_text. The other case (what
+        would have been generated if no modifiers were pressed) should be
+        covered by this as well.
+
+        As this method is used when handling access keys, tests such as
+        fast/events/access-key-self-destruct.html should now pass.
+
+        No new tests, as this fixes a problem uncovered by the existing ones.
+
+        * platform/efl/PlatformKeyboardEventEfl.cpp:
+        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
 2011-09-12  Hyowon Kim  <hw1008.kim@samsung.com>
 

trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp

@@ -192 +192 @@
     : m_type(KeyDown)
     , m_text(String::fromUTF8(event->string))
+    , m_unmodifiedText(String::fromUTF8(event->string))
     , m_shiftKey(evas_key_modifier_is_set(event->modifiers, "Shift"))
     , m_ctrlKey(evas_key_modifier_is_set(event->modifiers, "Control"))