Changeset 95009 in webkit

Timestamp:

Sep 12, 2011 8:50:01 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Setting document.title doesn't affect contents of title tag of XHTML documents
​https://bugs.webkit.org/show_bug.cgi?id=57537

Patch by Jacky Jiang <​zhajiang@rim.com> on 2011-09-12
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Update the contents of the <title> tag of XHTML documents when setting
document.title.

Test: fast/dom/title-content-set-innerText-get.xhtml

• dom/Document.cpp:

(WebCore::Document::setTitle):

LayoutTests:

• fast/dom/title-content-set-innerText-get-expected.txt: Added.
• fast/dom/title-content-set-innerText-get.xhtml: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/title-content-set-innerText-get-expected.txt (added)
• LayoutTests/fast/dom/title-content-set-innerText-get.xhtml (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-12  Jacky Jiang  <zhajiang@rim.com>
+
+        Setting document.title doesn't affect contents of title tag of XHTML documents
+        https://bugs.webkit.org/show_bug.cgi?id=57537
+
+        Reviewed by Alexey Proskuryakov.
+
+        * fast/dom/title-content-set-innerText-get-expected.txt: Added.
+        * fast/dom/title-content-set-innerText-get.xhtml: Added.
+
 2011-09-12  Dominic Mazzoni  <dmazzoni@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-12  Jacky Jiang  <zhajiang@rim.com>
+
+        Setting document.title doesn't affect contents of title tag of XHTML documents
+        https://bugs.webkit.org/show_bug.cgi?id=57537
+
+        Reviewed by Alexey Proskuryakov.
+
+        Update the contents of the <title> tag of XHTML documents when setting
+        document.title.
+
+        Test: fast/dom/title-content-set-innerText-get.xhtml
+
+        * dom/Document.cpp:
+        (WebCore::Document::setTitle):
+
 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1330 +1330 @@
     // Title set by JavaScript -- overrides any title elements.
     m_titleSetExplicitly = true;
-    if (!isHTMLDocument())
+    if (!isHTMLDocument() && !isXHTMLDocument())
         m_titleElement = 0;
     else if (!m_titleElement) {